Issue 955223002: Updates android build instructions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 955223002: Updates android build instructions. (Closed)

Created:
5 years, 10 months ago by sky

Modified:
5 years, 10 months ago

Reviewers:
tonyg

CC:
mojo-reviews_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Updates android build instructions. R=tonyg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/965eaf21a1b92019035a2099cbbeec1c2ea61132

Patch Set 2 : comment #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	README.md	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tonyg

lgtm https://codereview.chromium.org/955223002/diff/1/README.md File README.md (right): https://codereview.chromium.org/955223002/diff/1/README.md#newcode129 README.md:129: build/install-build-deps-android.sh For consistency, let's start this line with ...

5 years, 10 months ago (2015-02-26 00:22:59 UTC) #2

sky

Committed patchset #2 (id:20001) manually as 965eaf21a1b92019035a2099cbbeec1c2ea61132 (presubmit successful).

5 years, 10 months ago (2015-02-26 00:30:50 UTC) #3

sky

5 years, 10 months ago (2015-02-26 00:31:02 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/955223002/diff/1/README.md
File README.md (right):

https://codereview.chromium.org/955223002/diff/1/README.md#newcode129
README.md:129: build/install-build-deps-android.sh
On 2015/02/26 00:22:59, tonyg wrote:
> For consistency, let's start this line with "$ "

Done.

Expand Messages | Collapse Messages

Issue 955223002: Updates android build instructions. (Closed)

Description

Patch Set 1 #

Patch Set 2 : comment #

Messages