Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: Source/web/WebFrameWidgetImpl.cpp

Issue 955143002: Add setVisibilityState API to WebFrameWidget (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Review comments addressed Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/web/WebFrameWidgetImpl.h ('k') | public/web/WebFrameWidget.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 996 matching lines...) Expand 10 before | Expand all | Expand 10 after
1007 m_layerTreeView->registerViewportLayers(nullptr, pageScaleLayer, roo tScrollLayer->platformLayer(), nullptr); 1007 m_layerTreeView->registerViewportLayers(nullptr, pageScaleLayer, roo tScrollLayer->platformLayer(), nullptr);
1008 } else { 1008 } else {
1009 m_layerTreeView->clearRootLayer(); 1009 m_layerTreeView->clearRootLayer();
1010 m_layerTreeView->clearViewportLayers(); 1010 m_layerTreeView->clearViewportLayers();
1011 } 1011 }
1012 } 1012 }
1013 1013
1014 suppressInvalidations(false); 1014 suppressInvalidations(false);
1015 } 1015 }
1016 1016
1017 void WebFrameWidgetImpl::setVisibilityState(WebPageVisibilityState visibilitySta te, bool isInitialState)
1018 {
1019 if (!m_page)
1020 return;
1021
1022 ASSERT(visibilityState == WebPageVisibilityStateVisible || visibilityState = = WebPageVisibilityStateHidden || visibilityState == WebPageVisibilityStatePrere nder);
Nate Chapin 2015/02/26 21:16:34 I agree this is wonky, but if there's precedent, I
kenrb 2015/02/26 22:29:56 Or, I could just remove it. There is nothing I can
1023 m_page->setVisibilityState(static_cast<PageVisibilityState>(visibilityState) , isInitialState);
Nate Chapin 2015/02/26 21:16:34 Just to make sure I understand correctly, setVisib
kenrb 2015/02/26 22:29:56 Aha, no. :( This is what I was talking about befo
1024
1025 if (m_layerTreeView) {
1026 bool visible = visibilityState == WebPageVisibilityStateVisible;
1027 m_layerTreeView->setVisible(visible);
1028 }
1029 }
1030
1017 } // namespace blink 1031 } // namespace blink
OLDNEW
« no previous file with comments | « Source/web/WebFrameWidgetImpl.h ('k') | public/web/WebFrameWidget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698