Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 955113002: Rearrange mojo/nacl files. (Closed)

Created:
5 years, 10 months ago by Nick Bray (chromium)
Modified:
5 years, 9 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rearrange mojo/nacl files. Files that were previously generated are now checked in to make SDK and Chromium integration easier. Files needed to build mojo apps have been moved to //mojo/public/platform/nacl. Files needed to integrate NaCl with Mojo (used by the NaCl content handler and Chromium) have been moved to //nacl_bindings. This directory will be copied into the Chrome tree. //nacl_bindings_generator contains the script for regenerating the checked-in files. This script will likely go away when the NaCl bindings have stabilized. //mojo/nacl is deprecated and currently contains testing and build files specific to the Mojo repo. BUG=401761 R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b0e6d97c65a5f3b0c77c0820a40245974be25af9

Patch Set 1 #

Patch Set 2 : Move #

Patch Set 3 : Tweak #

Total comments: 7

Patch Set 4 : Cleanup GN #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1735 lines, -1479 lines) Patch
M mojo/nacl/BUILD.gn View 1 3 chunks +3 lines, -77 lines 0 comments Download
D mojo/nacl/generator/generate_nacl_bindings.py View 1 chunk +0 lines, -507 lines 0 comments Download
D mojo/nacl/generator/interface.py View 1 chunk +0 lines, -122 lines 0 comments Download
D mojo/nacl/generator/interface_dsl.py View 1 chunk +0 lines, -146 lines 0 comments Download
D mojo/nacl/generator/libmojo.cc.tmpl View 1 chunk +0 lines, -35 lines 0 comments Download
D mojo/nacl/generator/mojo_irt.c.tmpl View 1 chunk +0 lines, -43 lines 0 comments Download
D mojo/nacl/generator/mojo_irt.h.tmpl View 1 chunk +0 lines, -32 lines 0 comments Download
D mojo/nacl/generator/mojo_syscall.cc.tmpl View 1 chunk +0 lines, -111 lines 0 comments Download
D mojo/nacl/irt_entry_mojo.c View 1 chunk +0 lines, -21 lines 0 comments Download
D mojo/nacl/mojo_syscall.h View 1 chunk +0 lines, -26 lines 0 comments Download
D mojo/nacl/mojo_syscall_internal.h View 1 chunk +0 lines, -175 lines 0 comments Download
D mojo/nacl/monacl_sel_main.h View 1 chunk +0 lines, -25 lines 0 comments Download
D mojo/nacl/monacl_sel_main.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M mojo/nacl/monacl_shell.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A mojo/public/platform/nacl/BUILD.gn View 1 chunk +17 lines, -0 lines 0 comments Download
A mojo/public/platform/nacl/libmojo.cc View 1 chunk +226 lines, -0 lines 0 comments Download
A mojo/public/platform/nacl/mojo_irt.h View 1 chunk +100 lines, -0 lines 0 comments Download
M mojo/tools/roll/rev_sdk.py View 1 1 chunk +1 line, -0 lines 0 comments Download
A nacl_bindings/BUILD.gn View 1 2 3 1 chunk +42 lines, -0 lines 0 comments Download
A + nacl_bindings/irt_entry_mojo.c View 1 1 chunk +1 line, -1 line 0 comments Download
A nacl_bindings/mojo_irt.c View 1 1 chunk +357 lines, -0 lines 0 comments Download
A + nacl_bindings/mojo_syscall.h View 1 1 chunk +1 line, -1 line 0 comments Download
A nacl_bindings/mojo_syscall.cc View 1 1 chunk +879 lines, -0 lines 0 comments Download
A + nacl_bindings/mojo_syscall_internal.h View 1 9 chunks +48 lines, -53 lines 0 comments Download
A + nacl_bindings/monacl_sel_main.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + nacl_bindings/monacl_sel_main.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + nacl_bindings_generator/generate_nacl_bindings.py View 1 8 chunks +46 lines, -50 lines 0 comments Download
A + nacl_bindings_generator/interface.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + nacl_bindings_generator/interface_dsl.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + nacl_bindings_generator/libmojo.cc.tmpl View 1 1 chunk +1 line, -1 line 0 comments Download
A + nacl_bindings_generator/mojo_irt.c.tmpl View 1 1 chunk +1 line, -1 line 0 comments Download
A + nacl_bindings_generator/mojo_irt.h.tmpl View 1 2 chunks +3 lines, -4 lines 0 comments Download
A + nacl_bindings_generator/mojo_syscall.cc.tmpl View 1 1 chunk +2 lines, -2 lines 0 comments Download
M services/nacl/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
M services/nacl/content_handler_main.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (1 generated)
Nick Bray (chromium)
5 years, 10 months ago (2015-02-25 19:27:15 UTC) #2
Nick Bray (chromium)
Hmmm. I realized mojo/nacl_bindings => mojo/nacl/bindings might make sense. Tell me what you think.
5 years, 10 months ago (2015-02-25 20:24:49 UTC) #3
jamesr
Why not //nacl_bindings ?
5 years, 10 months ago (2015-02-25 20:38:22 UTC) #4
Nick Bray (chromium)
PTAL https://codereview.chromium.org/955113002/diff/40001/nacl_bindings/BUILD.gn File nacl_bindings/BUILD.gn (right): https://codereview.chromium.org/955113002/diff/40001/nacl_bindings/BUILD.gn#newcode17 nacl_bindings/BUILD.gn:17: rebase_path("mojo/public/c/system", ".", mojo_root), Note: a little funky, but ...
5 years, 10 months ago (2015-02-25 22:14:36 UTC) #5
jamesr
Seems pretty good. 2 questions below where I'm not sure exactly what's going on https://codereview.chromium.org/955113002/diff/40001/nacl_bindings/BUILD.gn ...
5 years, 10 months ago (2015-02-26 00:23:22 UTC) #6
Nick Bray (chromium)
https://codereview.chromium.org/955113002/diff/40001/nacl_bindings/BUILD.gn File nacl_bindings/BUILD.gn (right): https://codereview.chromium.org/955113002/diff/40001/nacl_bindings/BUILD.gn#newcode10 nacl_bindings/BUILD.gn:10: static_library("monacl_sel") { On 2015/02/26 00:23:22, jamesr wrote: > do ...
5 years, 10 months ago (2015-02-26 01:16:02 UTC) #7
jamesr
lgtm
5 years, 10 months ago (2015-02-26 01:36:48 UTC) #8
Nick Bray (chromium)
5 years, 9 months ago (2015-02-26 19:23:03 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
b0e6d97c65a5f3b0c77c0820a40245974be25af9.

Powered by Google App Engine
This is Rietveld 408576698