Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/objects.h

Issue 955063002: Fix memory leak caused by field type in descriptor array. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove unused var in release. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_OBJECTS_H_ 5 #ifndef V8_OBJECTS_H_
6 #define V8_OBJECTS_H_ 6 #define V8_OBJECTS_H_
7 7
8 #include <iosfwd> 8 #include <iosfwd>
9 9
10 #include "src/allocation.h" 10 #include "src/allocation.h"
(...skipping 6425 matching lines...) Expand 10 before | Expand all | Expand 10 after
6436 void ZapTransitions(); 6436 void ZapTransitions();
6437 6437
6438 void DeprecateTransitionTree(); 6438 void DeprecateTransitionTree();
6439 bool DeprecateTarget(PropertyKind kind, Name* key, 6439 bool DeprecateTarget(PropertyKind kind, Name* key,
6440 PropertyAttributes attributes, 6440 PropertyAttributes attributes,
6441 DescriptorArray* new_descriptors, 6441 DescriptorArray* new_descriptors,
6442 LayoutDescriptor* new_layout_descriptor); 6442 LayoutDescriptor* new_layout_descriptor);
6443 6443
6444 Map* FindLastMatchMap(int verbatim, int length, DescriptorArray* descriptors); 6444 Map* FindLastMatchMap(int verbatim, int length, DescriptorArray* descriptors);
6445 6445
6446 // Update field type of the given descriptor to new representation and new
6447 // type. The type must be prepared for storing in descriptor array:
6448 // it must be either a simple type or a map wrapped in a weak cell.
6446 void UpdateFieldType(int descriptor_number, Handle<Name> name, 6449 void UpdateFieldType(int descriptor_number, Handle<Name> name,
6447 Representation new_representation, 6450 Representation new_representation,
6448 Handle<HeapType> new_type); 6451 Handle<Object> new_wrapped_type);
6449 6452
6450 void PrintReconfiguration(FILE* file, int modify_index, PropertyKind kind, 6453 void PrintReconfiguration(FILE* file, int modify_index, PropertyKind kind,
6451 PropertyAttributes attributes); 6454 PropertyAttributes attributes);
6452 void PrintGeneralization(FILE* file, 6455 void PrintGeneralization(FILE* file,
6453 const char* reason, 6456 const char* reason,
6454 int modify_index, 6457 int modify_index,
6455 int split, 6458 int split,
6456 int descriptors, 6459 int descriptors,
6457 bool constant_to_field, 6460 bool constant_to_field,
6458 Representation old_representation, 6461 Representation old_representation,
(...skipping 4526 matching lines...) Expand 10 before | Expand all | Expand 10 after
10985 } else { 10988 } else {
10986 value &= ~(1 << bit_position); 10989 value &= ~(1 << bit_position);
10987 } 10990 }
10988 return value; 10991 return value;
10989 } 10992 }
10990 }; 10993 };
10991 10994
10992 } } // namespace v8::internal 10995 } } // namespace v8::internal
10993 10996
10994 #endif // V8_OBJECTS_H_ 10997 #endif // V8_OBJECTS_H_
OLDNEW
« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698