Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/ports_test.dart

Issue 955053002: adding codereview file, formatting, adding gitignore (Closed) Base URL: https://github.com/dart-lang/isolate.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« test/isolaterunner_test.dart ('K') | « test/isolaterunner_test.dart ('k') | test/registry_test.dart » ('j') | test/registry_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/ports_test.dart
diff --git a/test/ports_test.dart b/test/ports_test.dart
index 9586b96da680fb72cad877da7f9d1828eb057ac9..5c1e5e84f2218ede3cbc55c4bc7cfcf1ecc82f09 100644
--- a/test/ports_test.dart
+++ b/test/ports_test.dart
@@ -48,8 +48,7 @@ void testSingleCallbackPort() {
test("singleCallbackValueBeforeTimeout", () {
Completer completer = new Completer.sync();
- SendPort p = singleCallbackPort(completer.complete,
- timeout: MS * 500);
+ SendPort p = singleCallbackPort(completer.complete, timeout: MS * 500);
p.send(42);
return completer.future.then((v) {
expect(v, 42);
@@ -58,9 +57,7 @@ void testSingleCallbackPort() {
test("singleCallbackTimeout", () {
Completer completer = new Completer.sync();
- singleCallbackPort(completer.complete,
- timeout: MS * 100,
- timeoutValue: 37);
+ singleCallbackPort(completer.complete, timeout: MS * 100, timeoutValue: 37);
return completer.future.then((v) {
expect(v, 37);
});
@@ -69,8 +66,7 @@ void testSingleCallbackPort() {
test("singleCallbackTimeoutFirst", () {
Completer completer = new Completer.sync();
SendPort p = singleCallbackPort(completer.complete,
- timeout: MS * 100,
- timeoutValue: 37);
+ timeout: MS * 100, timeoutValue: 37);
Lasse Reichstein Nielsen 2015/02/26 10:59:15 Indent to after '(' or put completer.complete on n
new Timer(MS * 500, () => p.send(42));
return completer.future.then((v) {
expect(v, 37);
@@ -78,7 +74,6 @@ void testSingleCallbackPort() {
});
}
-
void testSingleCompletePort() {
test("singleCompleteValue", () {
Completer completer = new Completer.sync();
@@ -91,11 +86,10 @@ void testSingleCompletePort() {
test("singleCompleteValueCallback", () {
Completer completer = new Completer.sync();
- SendPort p = singleCompletePort(completer,
- callback: (v) {
- expect(42, v);
- return 87;
- });
+ SendPort p = singleCompletePort(completer, callback: (v) {
+ expect(42, v);
+ return 87;
+ });
Lasse Reichstein Nielsen 2015/02/26 10:59:15 This is much better!
p.send(42);
return completer.future.then((v) {
expect(v, 87);
@@ -104,12 +98,10 @@ void testSingleCompletePort() {
test("singleCompleteValueCallbackFuture", () {
Completer completer = new Completer.sync();
- SendPort p = singleCompletePort(completer,
- callback: (v) {
- expect(42, v);
- return new Future.delayed(MS * 500,
- () => 88);
- });
+ SendPort p = singleCompletePort(completer, callback: (v) {
+ expect(42, v);
+ return new Future.delayed(MS * 500, () => 88);
+ });
p.send(42);
return completer.future.then((v) {
expect(v, 88);
@@ -118,11 +110,10 @@ void testSingleCompletePort() {
test("singleCompleteValueCallbackThrows", () {
Completer completer = new Completer.sync();
- SendPort p = singleCompletePort(completer,
- callback: (v) {
- expect(42, v);
- throw 89;
- });
+ SendPort p = singleCompletePort(completer, callback: (v) {
+ expect(42, v);
+ throw 89;
+ });
p.send(42);
return completer.future.then((v) {
fail("unreachable");
@@ -133,11 +124,10 @@ void testSingleCompletePort() {
test("singleCompleteValueCallbackThrowsFuture", () {
Completer completer = new Completer.sync();
- SendPort p = singleCompletePort(completer,
- callback: (v) {
- expect(42, v);
- return new Future.error(90);
- });
+ SendPort p = singleCompletePort(completer, callback: (v) {
+ expect(42, v);
+ return new Future.error(90);
+ });
p.send(42);
return completer.future.then((v) {
fail("unreachable");
@@ -159,9 +149,9 @@ void testSingleCompletePort() {
test("singleCompleteFirstValueCallback", () {
Completer completer = new Completer.sync();
SendPort p = singleCompletePort(completer, callback: (v) {
- expect(v, 42);
- return 87;
- });
+ expect(v, 42);
+ return 87;
+ });
p.send(42);
p.send(37);
return completer.future.then((v) {
@@ -171,8 +161,7 @@ void testSingleCompletePort() {
test("singleCompleteValueBeforeTimeout", () {
Completer completer = new Completer.sync();
- SendPort p = singleCompletePort(completer,
- timeout: MS * 500);
+ SendPort p = singleCompletePort(completer, timeout: MS * 500);
p.send(42);
return completer.future.then((v) {
expect(v, 42);
@@ -181,8 +170,7 @@ void testSingleCompletePort() {
test("singleCompleteTimeout", () {
Completer completer = new Completer.sync();
- singleCompletePort(completer,
- timeout: MS * 100);
+ singleCompletePort(completer, timeout: MS * 100);
return completer.future.then((v) {
fail("unreachable");
}, onError: (e, s) {
@@ -192,9 +180,7 @@ void testSingleCompletePort() {
test("singleCompleteTimeoutCallback", () {
Completer completer = new Completer.sync();
- singleCompletePort(completer,
- timeout: MS * 100,
- onTimeout: () => 87);
+ singleCompletePort(completer, timeout: MS * 100, onTimeout: () => 87);
return completer.future.then((v) {
expect(v, 87);
});
@@ -202,9 +188,7 @@ void testSingleCompletePort() {
test("singleCompleteTimeoutCallbackThrows", () {
Completer completer = new Completer.sync();
- singleCompletePort(completer,
- timeout: MS * 100,
- onTimeout: () => throw 91);
+ singleCompletePort(completer, timeout: MS * 100, onTimeout: () => throw 91);
return completer.future.then((v) {
fail("unreachable");
}, onError: (e, s) {
@@ -215,8 +199,7 @@ void testSingleCompletePort() {
test("singleCompleteTimeoutCallbackFuture", () {
Completer completer = new Completer.sync();
singleCompletePort(completer,
- timeout: MS * 100,
- onTimeout: () => new Future.value(87));
+ timeout: MS * 100, onTimeout: () => new Future.value(87));
return completer.future.then((v) {
expect(v, 87);
});
@@ -225,8 +208,7 @@ void testSingleCompletePort() {
test("singleCompleteTimeoutCallbackThrowsFuture", () {
Completer completer = new Completer.sync();
singleCompletePort(completer,
- timeout: MS * 100,
- onTimeout: () => new Future.error(92));
+ timeout: MS * 100, onTimeout: () => new Future.error(92));
return completer.future.then((v) {
fail("unreachable");
}, onError: (e, s) {
@@ -236,8 +218,7 @@ void testSingleCompletePort() {
test("singleCompleteTimeoutCallbackSLow", () {
Completer completer = new Completer.sync();
- singleCompletePort(
- completer,
+ singleCompletePort(completer,
timeout: MS * 100,
onTimeout: () => new Future.delayed(MS * 500, () => 87));
return completer.future.then((v) {
@@ -247,8 +228,7 @@ void testSingleCompletePort() {
test("singleCompleteTimeoutCallbackThrowsSlow", () {
Completer completer = new Completer.sync();
- singleCompletePort(
- completer,
+ singleCompletePort(completer,
timeout: MS * 100,
onTimeout: () => new Future.delayed(MS * 500, () => throw 87));
return completer.future.then((v) {
@@ -260,9 +240,8 @@ void testSingleCompletePort() {
test("singleCompleteTimeoutFirst", () {
Completer completer = new Completer.sync();
- SendPort p = singleCompletePort(completer,
- timeout: MS * 100,
- onTimeout: () => 37);
+ SendPort p =
+ singleCompletePort(completer, timeout: MS * 100, onTimeout: () => 37);
new Timer(MS * 500, () => p.send(42));
return completer.future.then((v) {
expect(v, 37);
« test/isolaterunner_test.dart ('K') | « test/isolaterunner_test.dart ('k') | test/registry_test.dart » ('j') | test/registry_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698