adding codereview file, formatting, adding gitignore

test/registry_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart.pkg.isolate.test.registry;
 
 import "package:isolate/isolaterunner.dart";
 import "package:isolate/registry.dart";
 import "dart:async";
 import "dart:isolate";
@@ skipping 16 matching lines @@
 class Oddity {
   static const int EVEN = 0;
   static const int ODD = 1;
 }
 
 Future<List> waitAll(int n, Future action(int n)) {
   return Future.wait(new Iterable.generate(n, action));
 }
 
 void testLookup() {
-
   test("lookupAll", () {
     RegistryManager regman = new RegistryManager();
     Registry registry = regman.registry;
     return waitAll(10, (i) {
       var element = new Element(i);
       var tag = i.isEven ? Oddity.EVEN : Oddity.ODD;
       return registry.add(element, tags: [tag]);
-    })
-    .then((_) => registry.lookup())
-    .then((all) {
+    }).then((_) => registry.lookup()).then((all) {

[Lasse Reichstein Nielsen, 2015/02/26 10:59:15]

Less clear which operations are performed. The registry.lookup is the important
call in this test, and it's hidden in the middle of a line of of other stuff.

       expect(all.length, 10);
       expect(all.map((v) => v.id).toList()..sort(),
-             [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]);
-    })
-    .then((_) { regman.close(); });
+          [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]);
+    }).then((_) {
+      regman.close();
+    });
   });
 
   test("lookupOdd", () {
     RegistryManager regman = new RegistryManager();
     Registry registry = regman.registry;
     return waitAll(10, (i) {
       var element = new Element(i);
       var tag = i.isEven ? Oddity.EVEN : Oddity.ODD;
       return registry.add(element, tags: [tag]);
-    })
-    .then((_) =>registry.lookup(tags:[Oddity.ODD]))
-    .then((all) {
+    }).then((_) => registry.lookup(tags: [Oddity.ODD])).then((all) {
       expect(all.length, 5);
-      expect(all.map((v) => v.id).toList()..sort(),
-             [1, 3, 5, 7, 9]);
-    })
-    .then((_) { regman.close(); });
+      expect(all.map((v) => v.id).toList()..sort(), [1, 3, 5, 7, 9]);
+    }).then((_) {
+      regman.close();
+    });
   });
 
   test("lookupMax", () {
     RegistryManager regman = new RegistryManager();
     Registry registry = regman.registry;
     return waitAll(10, (i) {
       var element = new Element(i);
       var tag = i.isEven ? Oddity.EVEN : Oddity.ODD;
       return registry.add(element, tags: [tag]);
-    })
-    .then((_) => registry.lookup(max: 5))
-    .then((all) {
+    }).then((_) => registry.lookup(max: 5)).then((all) {
       expect(all.length, 5);
-    })
-    .then((_) { regman.close(); });
+    }).then((_) {
+      regman.close();
+    });
   });
 
   test("lookupMultiTag", () {
     RegistryManager regman = new RegistryManager();
     Registry registry = regman.registry;
     return waitAll(25, (i) {
       var element = new Element(i);
       // Collect all numbers dividing i.
       var tags = [i];
       for (int j = 2; j < 25; j++) {
         if (i % j == 0) tags.add(j);
       }
       return registry.add(element, tags: tags);
-    })
-    .then((_) => registry.lookup(tags: [2, 3]))
-    .then((all) {
+    }).then((_) => registry.lookup(tags: [2, 3])).then((all) {
       expect(all.length, 5);
-      expect(all.map((v) => v.id).toList()..sort(),
-             [0, 6, 12, 18, 24]);
-    })
-    .then((_) { regman.close(); });
+      expect(all.map((v) => v.id).toList()..sort(), [0, 6, 12, 18, 24]);
+    }).then((_) {
+      regman.close();
+    });
   });
 
   test("lookupMultiTagMax", () {
     RegistryManager regman = new RegistryManager();
     Registry registry = regman.registry;
     return waitAll(25, (i) {
       var element = new Element(i);
       // Collect all numbers dividing i.
       var tags = [i];
       for (int j = 2; j < 25; j++) {
         if (i % j == 0) tags.add(j);
       }
       return registry.add(element, tags: tags);
-    })
-    .then((_) => registry.lookup(tags: [2, 3], max: 3))
-    .then((all) {
+    }).then((_) => registry.lookup(tags: [2, 3], max: 3)).then((all) {
       expect(all.length, 3);
       expect(all.every((v) => (v.id % 6) == 0), isTrue);
-    })
-    .then((_) { regman.close(); });
+    }).then((_) {
+      regman.close();
+    });
   });
 }
 
 void testAddLookup() {
   test("Add-lookup-identical", () {
     RegistryManager regman = new RegistryManager();
     Registry registry = regman.registry;
     var object = new Object();
     return registry.add(object).then((_) {
       return registry.lookup().then((entries) {
         expect(entries, hasLength(1));
         expect(entries.first, same(object));
       });
     }).whenComplete(regman.close);
   });
 
   test("Add-multiple-identical", () {
     RegistryManager regman = new RegistryManager();
     Registry registry = regman.registry;
     var object1 = new Object();
     var object2 = new Object();
     var object3 = new Object();
     var objects = [object1, object2, object3];
-    return Future.wait(objects.map(registry.add))
-                 .then((_) {
+    return Future.wait(objects.map(registry.add)).then((_) {
       return registry.lookup().then((entries) {
         expect(entries, hasLength(3));
         for (var entry in entries) {
           expect(entry, isIn(objects));
         }
       });
     }).whenComplete(regman.close);
   });
 
   test("Add-twice", () {
@@ skipping 48 matching lines @@
       expect(entries.first, same(object));
     }).whenComplete(regman.close);
   });
 
   test("Add-multiple-tags", () {
     RegistryManager regman = new RegistryManager();
     Registry registry = regman.registry;
     var object1 = new Object();
     var object2 = new Object();
     var object3 = new Object();
-    return registry.add(object1, tags: [1, 3, 5, 7]).then((_){
+    return registry.add(object1, tags: [1, 3, 5, 7]).then((_) {
       return registry.add(object2, tags: [2, 3, 6, 7]);
     }).then((_) {
       return registry.add(object3, tags: [4, 5, 6, 7]);
     }).then((_) {
       return registry.lookup(tags: [3]).then((entries) {
         expect(entries, hasLength(2));
         expect(entries.first == object1 || entries.last == object1, isTrue);
         expect(entries.first == object2 || entries.last == object2, isTrue);
       });
     }).then((_) {
@@ skipping 93 matching lines @@
     }).whenComplete(regman.close);
   });
 
   test("Add-remove-multiple", () {
     RegistryManager regman = new RegistryManager();
     Registry registry = regman.registry;
     var object1 = new Object();
     var object2 = new Object();
     var object3 = new Object();
     var objects = [object1, object2, object3];
-    return Future.wait(objects.map(registry.add)).then((_){
+    return Future.wait(objects.map(registry.add)).then((_) {
       return registry.addTags([object1, object2], ["x", "y"]);
     }).then((_) {
       return registry.addTags([object1, object3], ["z", "w"]);
     }).then((_) {
       return registry.lookup(tags: ["x", "z"]);
     }).then((entries) {
       expect(entries, hasLength(1));
       expect(entries.first, same(object1));
       return registry.removeTags([object1, object2], ["x", "z"]);
     }).then((_) {
       return registry.lookup(tags: ["z"]);
     }).then((entries) {
       expect(entries, hasLength(1));
       expect(entries.first, same(object3));
     }).whenComplete(regman.close);
   });
 
   test("Remove-wrong-object", () {
     RegistryManager regman = new RegistryManager();
     Registry registry = regman.registry;
-    expect(() => registry.removeTags([new Object()], ["x"]),
-           throws);
+    expect(() => registry.removeTags([new Object()], ["x"]), throws);
     regman.close();
   });
 }
 
 var _regmen = {};
 Registry createRegMan(id) {
   var regman = new RegistryManager();
   _regmen[id] = regman;
   return regman.registry;
 }
 void closeRegMan(id) {
   _regmen.remove(id).close();
 }
 
 void testCrossIsolate() {
   var object = new Object();
   test("regman-other-isolate", () {
     // Add, lookup and remove object in other isolate.
     return IsolateRunner.spawn().then((isolate) {
       isolate.run(createRegMan, 1).then((registry) {
-        return registry.add(object, tags: ["a", "b"])
-                       .then((removeCapability) {
+        return registry.add(object, tags: ["a", "b"]).then((removeCapability) {
           return registry.lookup(tags: ["a"]).then((entries) {
             expect(entries, hasLength(1));
             expect(entries.first, same(object));
             return registry.remove(entries.first, removeCapability);
           }).then((removeSuccess) {
             expect(removeSuccess, isTrue);
           });
         });
       }).whenComplete(() {
         return isolate.run(closeRegMan, 1);
@@ skipping 140 matching lines @@
   testObject(new Element(42));
   testObject(#symbol);
   testObject(#_privateSymbol);
   testObject(new Capability());
 }
 
 class Element {
   final int id;
   Element(this.id);
   int get hashCode => id;
-  bool operator==(Object other) => other is Element && id == other.id;
+  bool operator ==(Object other) => other is Element && id == other.id;
 }