adding codereview file, formatting, adding gitignore

test/isolaterunner_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart.pkg.isolate.isolaterunner_test;
 
 import "package:isolate/isolaterunner.dart";
 import "package:unittest/unittest.dart";
 import "dart:async" show Future;
 import "dart:isolate" show Capability;
@@ skipping 17 matching lines @@
   return IsolateRunner.spawn().then((IsolateRunner runner) {
     return runner.run(id, "testCreateRunClose").then((v) {
       expect(v, "testCreateRunClose");
       return runner.close().then((_) => runner.onExit);
     });
   });
 }
 
 Future testSeparateIsolates() {
   // Check that each isolate has its own _global variable.
-  return Future.wait(new Iterable.generate(2, (_) => IsolateRunner.spawn()))
-    .then((runners) {
-      Future runAll(action(IsolateRunner runner, int index)) {
-        var indices = new Iterable.generate(runners.length);
-        return Future.wait(indices.map((i) => action(runners[i], i)));
-      }
+  return Future
+      .wait(new Iterable.generate(2, (_) => IsolateRunner.spawn()))
+      .then((runners) {
+    Future runAll(action(IsolateRunner runner, int index)) {

[Lasse Reichstein Nielsen, 2015/02/26 10:59:15]

Indent body by four more.

+      var indices = new Iterable.generate(runners.length);
+      return Future.wait(indices.map((i) => action(runners[i], i)));
+    }
 
-      return runAll((runner, i) => runner.run(setGlobal, i + 1))
-             .then((values) {
-               expect(values, [1, 2]);
-               expect(_global, null);
-               return runAll((runner, _) => runner.run(getGlobal, null));
-             })
-             .then((values) {
-               expect(values, [1, 2]);
-               expect(_global, null);
-               return runAll((runner, _) => runner.close());
-             });
+    return runAll((runner, i) => runner.run(setGlobal, i + 1)).then((values) {

[Lasse Reichstein Nielsen, 2015/02/26 10:59:15]

This one is acceptable, but I still think it's better when .then(values) are
indented where it's easier to see, so you can see where the "values" variable is
bound.

+      expect(values, [1, 2]);
+      expect(_global, null);
+      return runAll((runner, _) => runner.run(getGlobal, null));
+    }).then((values) {
+      expect(values, [1, 2]);
+      expect(_global, null);
+      return runAll((runner, _) => runner.close());
     });
+  });
 }
 
 void testIsolateFunctions() {
   test("pause", () {
     bool mayComplete = false;
     return IsolateRunner.spawn().then((isolate) {
       isolate.pause();
       new Future.delayed(MS * 500, () {
         mayComplete = true;
         isolate.resume();
@@ skipping 38 matching lines @@
       return isolate.kill();
     });
   });
 }
 
 id(x) => x;
 
 var _global;
 getGlobal(_) => _global;
 void setGlobal(v) => _global = v;