adding codereview file, formatting, adding gitignore

lib/registry.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * An isolate-compatible object registry and lookup service.
  */
 library dart.pkg.isolate.registry;
 
 import "dart:async" show Future, Completer, TimeoutException;
@@ skipping 56 matching lines @@
    * If a registry is used between isolates created using [Isolate.spawnUri],
    * the `Registry` object can't be sent between the isolates directly.
    * Instead the [RegistryManager.commandPort] port can be sent and a
    * `Registry` created from the command port using this constructor.
    *
    * The optional [timeout] parameter can be set to the duration
    * this registry should wait before assuming that an operation
    * has failed.
    */
   Registry.fromPort(SendPort commandPort,
-                    {Duration timeout: const Duration(seconds: 5)})
+      {Duration timeout: const Duration(seconds: 5)})

[Lasse Reichstein Nielsen, 2015/02/26 10:59:14]

Indent '{' to after '('.

       : _commandPort = commandPort,
         _timeout = timeout;
 
   _RegistryCache get _cache {
     _RegistryCache cache = _caches[this];
     if (cache != null) return cache;
     cache = new _RegistryCache();
     _caches[this] = cache;
     return cache;
   }
@@ skipping 164 matching lines @@
 
   final Map<int, Object> id2object = new HashMap();
   final Map<Object, int> object2id = new HashMap.identity();
 
   int id(Object object) {
     int result = object2id[object];
     if (result == _BEING_ADDED) return null;
     return result;
   }
 
-  Object operator[](int id) => id2object[id];
+  Object operator [](int id) => id2object[id];
 
   // Register a pair of id/object in the cache.
   // if the id is already in the cache, just return the existing
   // object.
   Object register(int id, Object object) {
     object = id2object.putIfAbsent(id, () {
       object2id[object] = id;
       return object;
     });
     return object;
   }
 
   bool isAdding(element) => object2id[element] == _BEING_ADDED;
 
-  void setAdding(element)  {
+  void setAdding(element) {
     assert(!contains(element));
     object2id[element] = _BEING_ADDED;
   }
 
   void stopAdding(element) {
     assert(object2id[element] == _BEING_ADDED);
     object2id.remove(element);
   }
 
   void remove(int id) {
@@ skipping 24 matching lines @@
   /**
    * Create a new registry managed by the created [RegistryManager].
    *
    * The optional [timeout] parameter can be set to the duration
    * registry objects should wait before assuming that an operation
    * has failed.
    */
   RegistryManager({timeout: const Duration(seconds: 5)})
       : _timeout = timeout,
         _commandPort = new RawReceivePort() {
-      _commandPort.handler = _handleCommand;
+    _commandPort.handler = _handleCommand;
   }
 
   /**
    * The command port receiving commands for the registry manager.
    *
    * Use this port with [Registry.fromPort] to link a registry to the
    * manager in isolates where you can't send a [Registry] object directly.
    */
   SendPort get commandPort => _commandPort.sendPort;
 
   /**
    * Get a registry backed by this manager.
    *
    * This registry can be sent to other isolates created using
    * [Isolate.spawn].
    */
-  Registry get registry => new Registry.fromPort(_commandPort.sendPort,
-                                                 timeout: _timeout);
+  Registry get registry =>
+      new Registry.fromPort(_commandPort.sendPort, timeout: _timeout);
 
   // Used as argument to putIfAbsent.
   static Set _createSet() => new HashSet();
 
   void _handleCommand(List command) {
-    switch(command[0]) {
+    switch (command[0]) {
       case _ADD:
         _add(command[1], command[2], command[3]);
         return;
       case _REMOVE:
         _remove(command[1], command[2], command[3]);
         return;
       case _ADD_TAGS:
         _addTags(command[1], command[2], command[3]);
         return;
       case _REMOVE_TAGS:
@@ skipping 34 matching lines @@
       _tag2id[tag].remove(id);
     }
     replyPort.send(true);
   }
 
   void _addTags(List<int> ids, List tags, SendPort replyPort) {
     assert(tags != null);
     assert(tags.isNotEmpty);
     for (int id in ids) {
       _RegistryEntry entry = _entries[id];
-      if (entry == null) continue;  // Entry was removed.
+      if (entry == null) continue; // Entry was removed.

[Lasse Reichstein Nielsen, 2015/02/26 10:59:14]

Two spaces before '//'.

       entry.tags.addAll(tags);
       for (var tag in tags) {
         Set ids = _tag2id.putIfAbsent(tag, _createSet);
         ids.add(id);
       }
     }
     replyPort.send(null);
   }
 
   void _removeTags(List<int> ids, List tags, SendPort replyPort) {
     assert(tags != null);
     assert(tags.isNotEmpty);
     for (int id in ids) {
       _RegistryEntry entry = _entries[id];
-      if (entry == null) continue;  // Object was removed.
+      if (entry == null) continue; // Object was removed.

[Lasse Reichstein Nielsen, 2015/02/26 10:59:15]

Ditto.

       entry.tags.removeAll(tags);
     }
     for (var tag in tags) {
       Set tagIds = _tag2id[tag];
       if (tagIds == null) continue;
       tagIds.removeAll(ids);
     }
     replyPort.send(null);
   }
 
@@ skipping 33 matching lines @@
       var entries = _entries.values;
       if (max != null) entries = entries.take(max);
       for (_RegistryEntry entry in entries) {
         result.add(entry.id);
         result.add(entry.element);
       }
       replyPort.send(result);
       return;
     }
     var matchingIds = _findTaggedIds(tags);
-    if (max == null) max = matchingIds.length;  // All results.
+    if (max == null) max = matchingIds.length; // All results.

[Lasse Reichstein Nielsen, 2015/02/26 10:59:15]

And ditto on the spaces.

     for (var id in matchingIds) {
       result.add(id);
       result.add(_entries[id].element);
       max--;
       if (max == 0) break;
     }
     replyPort.send(result);
   }
 
   /**
    * Shut down the registry service.
    *
    * After this, all [Registry] operations will time out.
    */
   void close() {
     _commandPort.close();
   }
 }
 
 /** Entry in [RegistryManager]. */
 class _RegistryEntry {
   final int id;
   final Object element;
   final Set tags = new HashSet();
   final Capability removeCapability = new Capability();
   _RegistryEntry(this.id, this.element);
 }