Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 955013002: Use the DrmDeviceManager to get the primary device in GbmSurfaceFactory (Closed)

Created:
5 years, 9 months ago by dnicoara
Modified:
5 years, 9 months ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the DrmDeviceManager to get the primary device in GbmSurfaceFactory Remove the requirement of a GBM device at construction time for GbmSurfaceFactory and switch to using EGL_DEFAULT_DISPLAY as a native display. This allows us to remove the hacks to open the "primary" graphics device in the GPU initialization. Graphics device initialization would be fully handled via hotplugging. BUG=427959 Committed: https://crrev.com/051001f2edf52d64239f5afc3ac68d9153ec2470 Cr-Commit-Position: refs/heads/master@{#318057}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -13 lines) Patch
M ui/ozone/platform/dri/gbm_surface_factory.h View 2 chunks +1 line, -3 lines 0 comments Download
M ui/ozone/platform/dri/gbm_surface_factory.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M ui/ozone/platform/dri/ozone_platform_gbm.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
dnicoara
PTAL
5 years, 9 months ago (2015-02-25 15:15:09 UTC) #2
alexst (slow to review)
lgtm
5 years, 9 months ago (2015-02-25 15:25:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955013002/1
5 years, 9 months ago (2015-02-25 16:25:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-25 16:27:55 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/051001f2edf52d64239f5afc3ac68d9153ec2470 Cr-Commit-Position: refs/heads/master@{#318057}
5 years, 9 months ago (2015-02-25 16:28:56 UTC) #7
vignatti (out of this project)
5 years, 9 months ago (2015-02-26 21:16:04 UTC) #8
Message was sent while issue was closed.
dnicoara@ this exact CL is breaking my system -- any idea how I can help to
track down the issue? This is ozone_demo's bt:

https://gist.githubusercontent.com/tiagovignatti/2e2db754472792c51387/raw/02c...

Powered by Google App Engine
This is Rietveld 408576698