Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 954993002: Revert of ServiceWorker: Use scheduler's default task queue for posting tasks on main thread (Closed)

Created:
5 years, 10 months ago by phoglund_chromium
Modified:
5 years, 10 months ago
CC:
chromium-reviews, michaeln, mlamouri+watch-content_chromium.org, tzik, serviceworker-reviews, jam, jsbell+serviceworker_chromium.org, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, kinuko+serviceworker, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ServiceWorker: Use scheduler's default task queue for posting tasks on main thread (patchset #1 id:1 of https://codereview.chromium.org/958523002/) Reason for revert: Highly speculative revert after views_unittests broke on win7: http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/35660 c:\b\build\slave\win_builder__dbg_\build\src\ui\views\accessibility\native_view_accessibility_win_unittest.cc(190): error: Value of: infobar_accessible.IsSameObject(targets[0]) This patch does change task queuing, which makes it seem slightly more likely to break stuff than the others in the blamelist. Original issue's description: > ServiceWorker: Use scheduler's default task queue for posting tasks on main thread > > This fixes a task ordering bug between WebMessagePortChannelImpl and > ServiceWorkerScriptContext. The former posts tasks via the Blink > scheduler's default task queue, and the latter was using the MessageLoop > directly. This patch makes tasks from service worker to the main thread > go through the scheduler. > > BUG=460833 > TEST=http/tests/serviceworker/postmessage-msgport-to-client.html > > Committed: https://crrev.com/a7fe515e3ca07e260b58ebf460f842601266ed87 > Cr-Commit-Position: refs/heads/master@{#318022} TBR=kinuko@chromium.org,skyostil@chromium.org,ksakamoto@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=460833 Committed: https://crrev.com/64250e71c15dfe3576d8e4077e4dfb04f9382482 Cr-Commit-Position: refs/heads/master@{#318040}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -17 lines) Patch
M content/renderer/service_worker/embedded_worker_context_client.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_context_client.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/service_worker/service_worker_script_context.cc View 4 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
phoglund_chromium
Created Revert of ServiceWorker: Use scheduler's default task queue for posting tasks on main thread
5 years, 10 months ago (2015-02-25 14:00:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954993002/1
5 years, 10 months ago (2015-02-25 14:01:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 14:01:42 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/64250e71c15dfe3576d8e4077e4dfb04f9382482 Cr-Commit-Position: refs/heads/master@{#318040}
5 years, 10 months ago (2015-02-25 14:02:12 UTC) #4
phoglund_chromium
5 years, 10 months ago (2015-02-25 16:27:03 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/957583003/ by phoglund@chromium.org.

The reason for reverting is: Test is still flaky, even after reverting this one.
For instance

http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/bui....

Powered by Google App Engine
This is Rietveld 408576698