Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 954953002: Adding GetTableAction method to Blink to handle color table tags (Closed)

Created:
5 years, 10 months ago by h.joshi
Modified:
5 years, 9 months ago
Reviewers:
behdad_google, eae, behdad
CC:
blink-reviews, Dominik Röttsches, krit, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Adding GetTableAction method to Blink to handle color table tags Need OTS update, so that this change works correctly and OTS is able to parse Color-Emoji font. Related OTS patch: https://codereview.chromium.org/966703002/ For compile and landing, this patch does not depend on above OTS patch. This patch only depends on OTS patch for proper functioning, so that uses defined fonts with color table are parsed correctly. Checked on Android, after this and OTS patch combined font (with color table) parsing is working fine. BUG=339857, 97467 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191612

Patch Set 1 #

Patch Set 2 : Add Color table parsing in Blink for OTS #

Patch Set 3 : Rebase patch #

Patch Set 4 : Comment fixes #

Patch Set 5 : Adding test case for font with color-table #

Patch Set 6 : Updating TestExpectations #

Patch Set 7 : Rebased Test expecttaion file #

Patch Set 8 : Updating Test Expectation for Virtual test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -4 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/emoji-web-font.html View 1 2 3 4 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/emoji-web-font-expected.png View 1 2 3 4 Binary file 0 comments Download
A LayoutTests/fast/text/emoji-web-font-expected.txt View 1 2 3 4 1 chunk +21 lines, -0 lines 0 comments Download
A LayoutTests/third_party/FruityGirl/002A.png View 1 2 3 4 Binary file 0 comments Download
A LayoutTests/third_party/FruityGirl/FruityGirl.ttf View 1 2 3 4 Binary file 0 comments Download
A LayoutTests/third_party/FruityGirl/LICENSE.txt View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/third_party/FruityGirl/README.chromium View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
M Source/platform/fonts/opentype/OpenTypeSanitizer.h View 1 2 3 2 chunks +28 lines, -0 lines 0 comments Download
M Source/platform/fonts/opentype/OpenTypeSanitizer.cpp View 1 2 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 25 (10 generated)
h.joshi
Pls review. On Windows bots, every times its failing in different cases.
5 years, 9 months ago (2015-03-03 12:03:55 UTC) #2
behdad_google
lgtm May be better to copy HB_TAG() and rename it. I actually filed that against ...
5 years, 9 months ago (2015-03-03 17:30:11 UTC) #4
eae
Can we add a test for this?
5 years, 9 months ago (2015-03-03 18:08:01 UTC) #5
h.joshi
On 2015/03/03 18:08:01, eae wrote: > Can we add a test for this?
5 years, 9 months ago (2015-03-04 06:17:48 UTC) #6
h.joshi
@Behdad: Made suggested changes. @Emil: Facing following two problems for test case: 1. On Linux, ...
5 years, 9 months ago (2015-03-04 06:19:32 UTC) #7
h.joshi
On my machine, Freetype call "FT_Open_Face" is returning NULL when NotoColorEmoji is used as user ...
5 years, 9 months ago (2015-03-04 07:21:41 UTC) #8
behdad_google
On 2015/03/04 07:21:41, h.joshi wrote: > On my machine, Freetype call "FT_Open_Face" is returning NULL ...
5 years, 9 months ago (2015-03-04 18:56:16 UTC) #9
h.joshi
Pls review. Layout test is added, for now only on Android correct rendering is shown. ...
5 years, 9 months ago (2015-03-09 05:15:25 UTC) #10
eae
LGTM, thank you!
5 years, 9 months ago (2015-03-09 22:59:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954953002/100001
5 years, 9 months ago (2015-03-09 23:00:52 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_dbg/builds/30886)
5 years, 9 months ago (2015-03-09 23:05:27 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954953002/120001
5 years, 9 months ago (2015-03-10 04:35:12 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/54189)
5 years, 9 months ago (2015-03-10 07:56:55 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954953002/140001
5 years, 9 months ago (2015-03-10 09:03:19 UTC) #24
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 10:34:22 UTC) #25
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191612

Powered by Google App Engine
This is Rietveld 408576698