Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3452)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 954943007: [Extensions] Make chrome://extensions use api functions for file access, reload (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/extensions/extension_settings_handler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index 7a4465289b060d3fb519b6bdc24a20cef7624306..b7ea12fcb854705a2afab322e09a821ba0f9878c 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -680,18 +680,12 @@ void ExtensionSettingsHandler::RegisterMessages() {
web_ui()->RegisterMessageCallback("extensionSettingsLaunch",
base::Bind(&ExtensionSettingsHandler::HandleLaunchMessage,
AsWeakPtr()));
- web_ui()->RegisterMessageCallback("extensionSettingsReload",
- base::Bind(&ExtensionSettingsHandler::HandleReloadMessage,
- AsWeakPtr()));
web_ui()->RegisterMessageCallback("extensionSettingsRepair",
base::Bind(&ExtensionSettingsHandler::HandleRepairMessage,
AsWeakPtr()));
web_ui()->RegisterMessageCallback("extensionSettingsEnableErrorCollection",
base::Bind(&ExtensionSettingsHandler::HandleEnableErrorCollectionMessage,
AsWeakPtr()));
- web_ui()->RegisterMessageCallback("extensionSettingsAllowFileAccess",
- base::Bind(&ExtensionSettingsHandler::HandleAllowFileAccessMessage,
- AsWeakPtr()));
web_ui()->RegisterMessageCallback("extensionSettingsAllowOnAllUrls",
base::Bind(&ExtensionSettingsHandler::HandleAllowOnAllUrlsMessage,
AsWeakPtr()));
@@ -995,13 +989,6 @@ void ExtensionSettingsHandler::HandleLaunchMessage(
extensions::SOURCE_EXTENSIONS_PAGE));
}
-void ExtensionSettingsHandler::HandleReloadMessage(
- const base::ListValue* args) {
- std::string extension_id = base::UTF16ToUTF8(ExtractStringValue(args));
- CHECK(!extension_id.empty());
- extension_service_->ReloadExtensionWithQuietFailure(extension_id);
-}
-
void ExtensionSettingsHandler::HandleRepairMessage(
const base::ListValue* args) {
std::string extension_id = base::UTF16ToUTF8(ExtractStringValue(args));
@@ -1026,31 +1013,6 @@ void ExtensionSettingsHandler::HandleEnableErrorCollectionMessage(
->SetReportingAllForExtension(extension_id, enabled);
}
-void ExtensionSettingsHandler::HandleAllowFileAccessMessage(
- const base::ListValue* args) {
- CHECK_EQ(2U, args->GetSize());
- std::string extension_id, allow_str;
- CHECK(args->GetString(0, &extension_id));
- CHECK(args->GetString(1, &allow_str));
- const Extension* extension =
- extension_service_->GetInstalledExtension(extension_id);
- if (!extension)
- return;
-
- if (util::IsExtensionSupervised(extension, Profile::FromWebUI(web_ui())))
- return;
-
- if (!management_policy_->UserMayModifySettings(extension, NULL)) {
- LOG(ERROR) << "An attempt was made to change allow file access of an"
- << " extension that is non-usermanagable. Extension id : "
- << extension->id();
- return;
- }
-
- util::SetAllowFileAccess(
- extension_id, extension_service_->profile(), allow_str == "true");
-}
-
void ExtensionSettingsHandler::HandleAllowOnAllUrlsMessage(
const base::ListValue* args) {
DCHECK(FeatureSwitch::scripts_require_action()->IsEnabled());
« no previous file with comments | « chrome/browser/ui/webui/extensions/extension_settings_handler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698