Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 954943006: Ensure the destination url reported to ImportHistory is correctly encoded. (Closed)

Created:
5 years, 10 months ago by Steve McKay
Modified:
5 years, 10 months ago
Reviewers:
hirono
CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org, Ben Kwa
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure the destination url reported to ImportHistory is correctly encoded. Eliminates a bug where files will spaces in name were not being marked as synced. Also: 1) Remove an unused method (with a TODO body) in ImportTask. BUG=461174 TEST=browser_test: FileManagerJsTest.* Committed: https://crrev.com/4cf03c77e61e92b6bf84955b006422b41927d23a Cr-Commit-Position: refs/heads/master@{#318197}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -22 lines) Patch
M ui/file_manager/file_manager/background/js/media_import_handler.js View 3 chunks +4 lines, -15 lines 2 comments Download
M ui/file_manager/file_manager/background/js/media_import_handler_unittest.js View 3 chunks +49 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/common/js/mock_entry.js View 1 chunk +6 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/common/js/test_importer_common.js View 3 chunks +25 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Steve McKay
5 years, 10 months ago (2015-02-25 17:25:27 UTC) #2
hirono
lgtm with a nit! https://codereview.chromium.org/954943006/diff/1/ui/file_manager/file_manager/background/js/media_import_handler.js File ui/file_manager/file_manager/background/js/media_import_handler.js (right): https://codereview.chromium.org/954943006/diff/1/ui/file_manager/file_manager/background/js/media_import_handler.js#newcode398 ui/file_manager/file_manager/background/js/media_import_handler.js:398: * @param {Entry} destinationEntry The ...
5 years, 10 months ago (2015-02-26 02:03:38 UTC) #3
Steve McKay
THanks! https://codereview.chromium.org/954943006/diff/1/ui/file_manager/file_manager/background/js/media_import_handler.js File ui/file_manager/file_manager/background/js/media_import_handler.js (right): https://codereview.chromium.org/954943006/diff/1/ui/file_manager/file_manager/background/js/media_import_handler.js#newcode398 ui/file_manager/file_manager/background/js/media_import_handler.js:398: * @param {Entry} destinationEntry The new destination entry. ...
5 years, 10 months ago (2015-02-26 05:15:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954943006/1
5 years, 10 months ago (2015-02-26 05:16:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-26 06:18:48 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 06:19:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4cf03c77e61e92b6bf84955b006422b41927d23a
Cr-Commit-Position: refs/heads/master@{#318197}

Powered by Google App Engine
This is Rietveld 408576698