ui/events/test/event_generator.cc - Issue 954943003: [KeyboardEvent] Use DOM |code| rather than Windows-based key code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/test/event_generator.cc

Issue 954943003: [KeyboardEvent] Use DOM |code| rather than Windows-based key code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added missing VKEY in windows for brightness and power Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine_unittest.cc ('k') | ui/views/controls/menu/menu_event_dispatcher_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/events/test/event_generator.cc

diff --git a/ui/events/test/event_generator.cc b/ui/events/test/event_generator.cc

index 9142d5c0c6ed661c9b68bcc03136743ecc3e555f..b4478d9e5716ef1287a2c8fbe3005968716a61e4 100644

--- a/ui/events/test/event_generator.cc

+++ b/ui/events/test/event_generator.cc

@@ -522,7 +522,8 @@ void EventGenerator::DispatchKeyEvent(bool is_press,

int flags) {

#if defined(OS_WIN)

UINT key_press = WM_KEYDOWN;

- uint16 character = ui::GetCharacterFromKeyCode(key_code, flags);

+ DomCode code = ui::KeyboardCodeToDomCode(key_code);

+ uint16 character = ui::DomCodeToCharacter(code, flags);

if (is_press && character) {

MSG native_event = { NULL, WM_KEYDOWN, key_code, 0 };

TestKeyEvent keyev(native_event, flags);