ui/events/keycodes/keyboard_codes_win.h - Issue 954943003: [KeyboardEvent] Use DOM |code| rather than Windows-based key code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/keycodes/keyboard_codes_win.h

Issue 954943003: [KeyboardEvent] Use DOM |code| rather than Windows-based key code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added missing VKEY in windows for brightness and power Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/events/keycodes/keyboard_codes_win.h

diff --git a/ui/events/keycodes/keyboard_codes_win.h b/ui/events/keycodes/keyboard_codes_win.h

index 396d38bea7ef4ec48068746f6acb41fed14f0edd..a2bb6452a9048dee2676e26b3d8b5043f82b35f0 100644

--- a/ui/events/keycodes/keyboard_codes_win.h

+++ b/ui/events/keycodes/keyboard_codes_win.h

@@ -182,6 +182,11 @@ enum KeyboardCode {

VKEY_OEM_CLEAR = VK_OEM_CLEAR,

VKEY_UNKNOWN = 0,

+ // These keys are defined in POSIX but not in Windows

+ VKEY_POWER = VKEY_UNKNOWN,

+ VKEY_BRIGHTNESS_DOWN = VKEY_UNKNOWN,

+ VKEY_BRIGHTNESS_UP = VKEY_UNKNOWN,

// Windows does not have a specific key code for AltGr. We use the unused

// VK_OEM_AX to represent AltGr, matching the behaviour of Firefox on Linux.

VKEY_ALTGR = VK_OEM_AX,

« no previous file with comments | « ui/events/keycodes/keyboard_code_conversion_xkb.cc ('k') | ui/events/keycodes/xkb_keysym.h » ('j') | no next file with comments »