Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: ui/events/keycodes/keyboard_code_conversion_xkb.h

Issue 954943003: [KeyboardEvent] Use DOM |code| rather than Windows-based key code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added missing VKEY in windows for brightness and power Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/keycodes/keyboard_code_conversion_xkb.h
diff --git a/ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.h b/ui/events/keycodes/keyboard_code_conversion_xkb.h
similarity index 71%
rename from ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.h
rename to ui/events/keycodes/keyboard_code_conversion_xkb.h
index fb5b89591e70b32c9a979edbf8d951971bbdd23d..b5f0740c0ec1ad666f66b2bd3c5894cf891916bf 100644
--- a/ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.h
+++ b/ui/events/keycodes/keyboard_code_conversion_xkb.h
@@ -1,18 +1,14 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
+// Copyright 2015 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef UI_EVENTS_OZONE_LAYOUT_XKB_XKB_KEYBOARD_CODE_CONVERSION_H_
#define UI_EVENTS_OZONE_LAYOUT_XKB_XKB_KEYBOARD_CODE_CONVERSION_H_
-// TODO(kpschoedel): move this file out of Ozone so that it can be used to
-// determine DomKey for desktop X11, OR switch desktop X11 to use the Ozone
-// keyboard layout interface.
-
-#include <xkbcommon/xkbcommon.h>
+// These functions are used by X11 targets and by Ozone/XKBcommon targets.
#include "base/strings/string16.h"
-#include "ui/events/keycodes/keyboard_codes.h"
+#include "ui/events/keycodes/xkb_keysym.h"
namespace ui {
@@ -27,6 +23,9 @@ DomKey NonPrintableXkbKeySymToDomKey(xkb_keysym_t keysym);
// or 0 if the keysym is not recognized.
base::char16 DeadXkbKeySymToCombiningCharacter(xkb_keysym_t keysym);
+// Return the DomKey determined by the XKB layout result (keysym, character).
+DomKey XkbKeySymToDomKey(xkb_keysym_t keysym, base::char16 character);
+
} // namespace ui
#endif // UI_EVENTS_OZONE_LAYOUT_XKB_XKB_KEYBOARD_CODE_CONVERSION_H_
« no previous file with comments | « ui/events/keycodes/keyboard_code_conversion_x.cc ('k') | ui/events/keycodes/keyboard_code_conversion_xkb.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698