Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2078)

Unified Diff: ui/events/keycodes/keyboard_code_conversion_x.h

Issue 954943003: [KeyboardEvent] Use DOM |code| rather than Windows-based key code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added missing VKEY in windows for brightness and power Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/keycodes/keyboard_code_conversion.cc ('k') | ui/events/keycodes/keyboard_code_conversion_x.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/keycodes/keyboard_code_conversion_x.h
diff --git a/ui/events/keycodes/keyboard_code_conversion_x.h b/ui/events/keycodes/keyboard_code_conversion_x.h
index 4bf696e240e4007771e5151d538052c14a2c57ca..0b8960f348aebea3bf2782043a7a290f59ad9489 100644
--- a/ui/events/keycodes/keyboard_code_conversion_x.h
+++ b/ui/events/keycodes/keyboard_code_conversion_x.h
@@ -6,6 +6,7 @@
#define UI_EVENTS_KEYCODES_KEYBOARD_CODE_CONVERSION_X_H_
#include "base/basictypes.h"
+#include "base/strings/string16.h"
#include "ui/events/events_base_export.h"
#include "ui/events/keycodes/keyboard_codes_posix.h"
@@ -15,6 +16,7 @@ typedef struct _XDisplay XDisplay;
namespace ui {
enum class DomCode;
+enum class DomKey;
EVENTS_BASE_EXPORT KeyboardCode KeyboardCodeFromXKeyEvent(const XEvent* xev);
@@ -25,6 +27,11 @@ EVENTS_BASE_EXPORT DomCode CodeFromXEvent(const XEvent* xev);
// Returns a character on a standard US PC keyboard from an XEvent.
EVENTS_BASE_EXPORT uint16 GetCharacterFromXEvent(const XEvent* xev);
+// Returns a DomKey and character from an XEvent.
+EVENTS_BASE_EXPORT void GetMeaningFromXEvent(const XEvent* xev,
+ DomKey* key,
+ base::char16* character);
+
// Converts a KeyboardCode into an X KeySym.
EVENTS_BASE_EXPORT int XKeysymForWindowsKeyCode(KeyboardCode keycode,
bool shift);
« no previous file with comments | « ui/events/keycodes/keyboard_code_conversion.cc ('k') | ui/events/keycodes/keyboard_code_conversion_x.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698