ui/base/accelerators/accelerator.cc - Issue 954943003: [KeyboardEvent] Use DOM |code| rather than Windows-based key code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/accelerators/accelerator.cc

Issue 954943003: [KeyboardEvent] Use DOM |code| rather than Windows-based key code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added missing VKEY in windows for brightness and power Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/base/accelerators/accelerator.cc

diff --git a/ui/base/accelerators/accelerator.cc b/ui/base/accelerators/accelerator.cc

index 4bf3b37ddac017a50a1984d0792bd2d719ec6561..0113f8791fd5559a9ba3cfc34dcfedfac0a55c38 100644

--- a/ui/base/accelerators/accelerator.cc

+++ b/ui/base/accelerators/accelerator.cc

@@ -197,7 +197,8 @@ base::string16 Accelerator::GetShortcutText() const {

key = LOWORD(::MapVirtualKeyW(key_code_, MAPVK_VK_TO_CHAR));

shortcut += key;

#elif defined(USE_AURA) || defined(OS_MACOSX)

- const uint16 c = GetCharacterFromKeyCode(key_code_, false);

+ DomCode code = KeyboardCodeToDomCode(key_code_);

+ const uint16 c = DomCodeToCharacter(code, false);

if (c != 0)

shortcut +=

static_cast<base::string16::value_type>(base::ToUpperASCII(c));

« no previous file with comments | « content/renderer/render_view_browsertest.cc ('k') | ui/events/BUILD.gn » ('j') | no next file with comments »