Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 954933004: Upstream Account chooser fragment of First Run. (Closed)

Created:
5 years, 9 months ago by aurimas (slooooooooow)
Modified:
5 years, 9 months ago
Reviewers:
jbudorick, newt (away)
CC:
chromium-reviews, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream Account chooser fragment of First Run. BUG=428842 TBR=jbudorick@chromium.org Committed: https://crrev.com/60f51ca8e82d50652f3e77e49890f38e8a367988 Cr-Commit-Position: refs/heads/master@{#318280}

Patch Set 1 #

Patch Set 2 : Update copyright dates #

Total comments: 1

Patch Set 3 : Update choose account string #

Patch Set 4 : Fix findbugs #

Patch Set 5 : Suppress findbugs #

Patch Set 6 : Another attempt to suppress findbugs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1637 lines, -8 lines) Patch
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A chrome/android/java/res/drawable-hdpi/fre_placeholder.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-hdpi/signin_promo_illustration.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/fre_placeholder.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/signin_promo_illustration.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/fre_placeholder.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/signin_promo_illustration.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/fre_placeholder.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/signin_promo_illustration.png View Binary file 0 comments Download
A chrome/android/java/res/layout/fre_choose_account.xml View 1 chunk +125 lines, -0 lines 0 comments Download
A + chrome/android/java/res/layout/fre_spinner_dropdown.xml View 1 chunk +8 lines, -8 lines 0 comments Download
A chrome/android/java/res/layout/fre_spinner_text.xml View 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/android/java/res/values/colors.xml View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/firstrun/AccountFirstRunFragment.java View 1 4 5 1 chunk +124 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/firstrun/AccountFirstRunView.java View 1 chunk +503 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPage.java View 1 chunk +96 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java View 1 chunk +98 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/firstrun/ImageCarousel.java View 1 chunk +410 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/firstrun/ProfileDataCache.java View 1 1 chunk +181 lines, -0 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 2 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
aurimas (slooooooooow)
newt: PTAL
5 years, 9 months ago (2015-02-26 01:26:05 UTC) #2
newt (away)
On 2015/02/26 01:26:05, aurimas wrote: > newt: PTAL lgtm!
5 years, 9 months ago (2015-02-26 01:41:47 UTC) #3
newt (away)
https://chromiumcodereview.appspot.com/954933004/diff/20001/chrome/android/java/strings/android_chrome_strings.grd File chrome/android/java/strings/android_chrome_strings.grd (right): https://chromiumcodereview.appspot.com/954933004/diff/20001/chrome/android/java/strings/android_chrome_strings.grd#newcode1288 chrome/android/java/strings/android_chrome_strings.grd:1288: Choose accounts s/accounts/account
5 years, 9 months ago (2015-02-26 01:42:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954933004/60001
5 years, 9 months ago (2015-02-26 01:46:11 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/51384)
5 years, 9 months ago (2015-02-26 02:35:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954933004/100001
5 years, 9 months ago (2015-02-26 18:47:02 UTC) #13
jbudorick
/build/android lgtm
5 years, 9 months ago (2015-02-26 18:51:52 UTC) #14
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 9 months ago (2015-02-26 19:28:28 UTC) #15
commit-bot: I haz the power
5 years, 9 months ago (2015-02-26 19:29:07 UTC) #16
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/60f51ca8e82d50652f3e77e49890f38e8a367988
Cr-Commit-Position: refs/heads/master@{#318280}

Powered by Google App Engine
This is Rietveld 408576698