Issue 95493004: Editing - Code refactoring to avoid several calls to rendererIsEditable() in loop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 95493004: Editing - Code refactoring to avoid several calls to rendererIsEditable() in loop (Closed)

Created:
7 years ago by vanihegde

Modified:
7 years ago

Reviewers:
leviw_travelin_and_unemployed, yosin_UTC9, ojan

CC:
blink-reviews, vanivhegde

Base URL:
https://chromium.googlesource.com/chromium/blink.git@bgColorIssue

Visibility:
Public.

More Reviews

Description

Editing - Code refactoring to avoid several calls to rendererIsEditable() in loop In startOfParagraph() and endOfParagraph(), rendererIsEditable() is called repeatedly in loop for a node that remains unchanged throughout the function. This is avoided by using a local variable. TEST=No test added, since it is a refactoring. All the layout tests have been successfully executed. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163268

Patch Set 1 #

Total comments: 2

Patch Set 2 : Renaming to startNodeIsEditable #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	Source/core/editing/VisibleUnits.cpp	View	1	2 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ojan

lgtm https://codereview.chromium.org/95493004/diff/1/Source/core/editing/VisibleUnits.cpp File Source/core/editing/VisibleUnits.cpp (right): https://codereview.chromium.org/95493004/diff/1/Source/core/editing/VisibleUnits.cpp#newcode1113 Source/core/editing/VisibleUnits.cpp:1113: bool editable = startNode->rendererIsEditable(); How about calling this ...

7 years ago (2013-12-04 20:47:41 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vani.hegde@samsung.com/95493004/20001

7 years ago (2013-12-05 13:47:32 UTC) #4

Message was sent while issue was closed.

Change committed as 163268

Expand Messages | Collapse Messages