Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 954883003: Remove privet_http_asynchronous_factory_mac.* (Closed)

Created:
5 years, 10 months ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove privet_http_asynchronous_factory_mac.* Mac implementation just one line, and it probably should gone after MAC implementation of LocalDomainResolver is done. BUG=461504 Committed: https://crrev.com/830ccc4c45969c05684bb8e6919197706859d0ec Cr-Commit-Position: refs/heads/master@{#318082}

Patch Set 1 #

Patch Set 2 : Wed Feb 25 00:21:30 PST 2015 #

Patch Set 3 : Wed Feb 25 09:01:01 PST 2015 #

Patch Set 4 : Wed Feb 25 09:06:16 PST 2015 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -113 lines) Patch
M chrome/browser/local_discovery/privet_http_asynchronous_factory.cc View 1 2 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_asynchronous_factory_impl.cc View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
D chrome/browser/local_discovery/privet_http_asynchronous_factory_mac.h View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/local_discovery/privet_http_asynchronous_factory_mac.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Vitaly Buka (NO REVIEWS)
5 years, 10 months ago (2015-02-25 17:02:51 UTC) #1
Vitaly Buka (NO REVIEWS)
5 years, 10 months ago (2015-02-25 17:06:47 UTC) #3
Aleksey Shlyapnikov
lgtm
5 years, 10 months ago (2015-02-25 17:16:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954883003/60001
5 years, 10 months ago (2015-02-25 17:16:57 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-25 18:46:25 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 18:47:28 UTC) #8
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/830ccc4c45969c05684bb8e6919197706859d0ec
Cr-Commit-Position: refs/heads/master@{#318082}

Powered by Google App Engine
This is Rietveld 408576698