Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 954873002: Fix content_browsertests on Linux GN build. (Closed)

Created:
5 years, 10 months ago by jam
Modified:
5 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix content_browsertests on Linux GN build. BUG=461044 Committed: https://crrev.com/b3dd04980de9b7bb42c5ca198b3152cbf485c956 Cr-Commit-Position: refs/heads/master@{#318078}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -39 lines) Patch
M components/pdf/renderer/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/BUILD.gn View 1 2 3 3 chunks +7 lines, -1 line 0 comments Download
M ppapi/BUILD.gn View 1 chunk +12 lines, -13 lines 0 comments Download
M ppapi/ppapi_internal.gyp View 1 chunk +0 lines, -15 lines 0 comments Download
M ppapi/shared_impl/BUILD.gn View 1 2 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
jam
5 years, 10 months ago (2015-02-25 07:16:51 UTC) #2
brettw
lgtm https://codereview.chromium.org/954873002/diff/20001/content/test/BUILD.gn File content/test/BUILD.gn (right): https://codereview.chromium.org/954873002/diff/20001/content/test/BUILD.gn#newcode416 content/test/BUILD.gn:416: deps += [ "//ppapi:ppapi_tests" ] Can you make ...
5 years, 10 months ago (2015-02-25 16:40:38 UTC) #3
jam
https://codereview.chromium.org/954873002/diff/20001/content/test/BUILD.gn File content/test/BUILD.gn (right): https://codereview.chromium.org/954873002/diff/20001/content/test/BUILD.gn#newcode416 content/test/BUILD.gn:416: deps += [ "//ppapi:ppapi_tests" ] On 2015/02/25 16:40:38, brettw ...
5 years, 10 months ago (2015-02-25 16:55:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954873002/40001
5 years, 10 months ago (2015-02-25 16:56:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/46454) linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 10 months ago (2015-02-25 17:14:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954873002/60001
5 years, 10 months ago (2015-02-25 17:19:03 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-25 18:23:07 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 18:23:47 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b3dd04980de9b7bb42c5ca198b3152cbf485c956
Cr-Commit-Position: refs/heads/master@{#318078}

Powered by Google App Engine
This is Rietveld 408576698