Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 954833005: scheduler: Trace queue size at post time (Closed)

Created:
5 years, 10 months ago by Sami
Modified:
5 years, 10 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, scheduler-bugs_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

scheduler: Trace queue size at post time Trace the task queue size when a task gets posted into it in addition to when we reload the work queue. This makes it easier to see when tasks are posted from a trace. Committed: https://crrev.com/294c455b12087569af1d3a8b94c95e3ae80ad718 Cr-Commit-Position: refs/heads/master@{#318038}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M content/renderer/scheduler/task_queue_manager.cc View 1 4 chunks +16 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Sami
5 years, 10 months ago (2015-02-25 12:29:38 UTC) #2
alex clarke (OOO till 29th)
https://codereview.chromium.org/954833005/diff/1/content/renderer/scheduler/task_queue_manager.cc File content/renderer/scheduler/task_queue_manager.cc (right): https://codereview.chromium.org/954833005/diff/1/content/renderer/scheduler/task_queue_manager.cc#newcode176 content/renderer/scheduler/task_queue_manager.cc:176: if (!is_locked) Did you consider using lock_.Try() here?
5 years, 10 months ago (2015-02-25 12:37:51 UTC) #3
alex clarke (OOO till 29th)
lgtm https://codereview.chromium.org/954833005/diff/1/content/renderer/scheduler/task_queue_manager.cc File content/renderer/scheduler/task_queue_manager.cc (right): https://codereview.chromium.org/954833005/diff/1/content/renderer/scheduler/task_queue_manager.cc#newcode176 content/renderer/scheduler/task_queue_manager.cc:176: if (!is_locked) On 2015/02/25 12:37:51, alexclarke1 wrote: > ...
5 years, 10 months ago (2015-02-25 12:38:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954833005/20001
5 years, 10 months ago (2015-02-25 12:53:00 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-25 13:46:52 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 13:47:43 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/294c455b12087569af1d3a8b94c95e3ae80ad718
Cr-Commit-Position: refs/heads/master@{#318038}

Powered by Google App Engine
This is Rietveld 408576698