Issue 954833004: Revert of Rebase GDBJIT interface solely on JITCodeEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 954833004: Revert of Rebase GDBJIT interface solely on JITCodeEvent (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer

Modified:
5 years, 9 months ago

Reviewers:
wingo, Michael Starzinger

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of Rebase GDBJIT interface solely on JITCodeEvent (patchset #2 id:20001 of https://codereview.chromium.org/957673004/) Reason for revert: Doesn't compile Original issue's description: > Rebase GDBJIT interface solely on JITCodeEvent > > R=mstarzinger@chromium.org > BUG= > > Committed: https://chromium.googlesource.com/v8/v8/+/8989d828e86bc7edae5e25687bcb60c0e301dffb TBR=mstarzinger@chromium.org,wingo@igalia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/49b112e117143d6443e85a1a08b9a12caeaa8e67 Cr-Commit-Position: refs/heads/master@{#26848}

Created: 5 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+300 lines, -242 lines)			Patch
M	src/compiler.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	src/flag-definitions.h	View	2 chunks	+24 lines, -35 lines	0 comments	Download
M	src/gdb-jit.h	View	1 chunk	+39 lines, -24 lines	0 comments	Download
M	src/gdb-jit.cc	View	17 chunks	+217 lines, -183 lines	0 comments	Download
M	src/heap/mark-compact.cc	View	3 chunks	+15 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Benedikt Meurer

Created Revert of Rebase GDBJIT interface solely on JITCodeEvent

5 years, 9 months ago (2015-02-25 12:02:35 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954833004/1

5 years, 9 months ago (2015-02-25 12:02:44 UTC) #2

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/49b112e117143d6443e85a1a08b9a12caeaa8e67 Cr-Commit-Position: refs/heads/master@{#26848}

5 years, 9 months ago (2015-02-25 12:03:14 UTC) #4

Message was sent while issue was closed.

LGTM (post-TBR-rubber-stamped).