Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Issue 954793002: Make load events in iframe elements work with OOPIF (Chromium side). (Closed)

Created:
5 years, 10 months ago by alexmos
Modified:
5 years, 10 months ago
Reviewers:
nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make load events in iframe elements work with OOPIF (Chromium side). Today, when the parent frame defines a load event handler in the iframe element of an out-of-process child frame, the event does not fire in the parent process. This CL adds the plumbing to forward the event from the child frame's process to the parent frame's process. Blink side: https://codereview.chromium.org/937203003 BUG=453690 Committed: https://crrev.com/f40ce5b0e297205977af598a5ebc6c5c920c4a4a Cr-Commit-Position: refs/heads/master@{#318101}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rename DispatchFrameOwnerLoadEvent to DispatchLoadEventForFrameOwner #

Total comments: 2

Patch Set 4 : Route through RenderFrameProxy instead of parent RFH #

Patch Set 5 : git cl format #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -0 lines) Patch
M content/browser/frame_host/render_frame_host_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 3 4 5 2 chunks +16 lines, -0 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 2 3 4 5 1 chunk +34 lines, -0 lines 0 comments Download
M content/common/frame_messages.h View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/render_frame_proxy.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_proxy.cc View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
A content/test/data/frame_with_load_event.html View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
alexmos
Nasko, do you mind reviewing this CL? This should fix one of the two roadblocks ...
5 years, 10 months ago (2015-02-24 20:10:23 UTC) #2
nasko
As we chatted, it will be better if the IPC is routed through the RenderFrameProxy ...
5 years, 10 months ago (2015-02-24 22:47:11 UTC) #3
alexmos
Thanks, I've changed this to route through the RenderFrameProxy as we discussed. I really like ...
5 years, 10 months ago (2015-02-24 23:31:18 UTC) #4
nasko
LGTM
5 years, 10 months ago (2015-02-24 23:50:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954793002/80001
5 years, 10 months ago (2015-02-25 17:41:19 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/62069)
5 years, 10 months ago (2015-02-25 17:46:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954793002/100001
5 years, 10 months ago (2015-02-25 19:08:05 UTC) #12
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 10 months ago (2015-02-25 20:20:25 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 20:21:15 UTC) #14
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/f40ce5b0e297205977af598a5ebc6c5c920c4a4a
Cr-Commit-Position: refs/heads/master@{#318101}

Powered by Google App Engine
This is Rietveld 408576698