Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 954763002: [Telemetry] Update facebook credential & reenable memory.top_7_stress (Closed)

Created:
5 years, 10 months ago by nednguyen
Modified:
5 years, 10 months ago
Reviewers:
sullivan, dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Update facebook credential & reenable memory.top_7_stress Reland patch from issue 951773002 at patchset 1 (http://crrev.com/951773002#ps1). Rerecord & upload the wpr file to cloud storage. To reviewers: to make sure that this doesn't produce the same problem in https://codereview.chromium.org/952963002/, please wait for https://codereview.chromium.org/954753002/ to be landed first. BUG=459646 Committed: https://crrev.com/5b570913b6d7a9254a43c576614c6d2de53df78e Cr-Commit-Position: refs/heads/master@{#317975}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M tools/perf/benchmarks/memory.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/top_7_stress.json View 2 chunks +3 lines, -1 line 0 comments Download
A tools/perf/page_sets/data/top_7_stress_004.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/top_7_stress.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
nednguyen
5 years, 10 months ago (2015-02-24 18:50:44 UTC) #3
sullivan
lgtm
5 years, 10 months ago (2015-02-24 18:53:53 UTC) #4
dtu
lgtm
5 years, 10 months ago (2015-02-24 19:04:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954763002/20001
5 years, 10 months ago (2015-02-25 02:38:22 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/45294)
5 years, 10 months ago (2015-02-25 03:09:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954763002/20001
5 years, 10 months ago (2015-02-25 03:37:56 UTC) #11
nednguyen
On 2015/02/25 03:09:55, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 10 months ago (2015-02-25 03:38:50 UTC) #12
slamm
On 2015/02/25 03:38:50, nednguyen wrote: > On 2015/02/25 03:09:55, I haz the power (commit-bot) wrote: ...
5 years, 10 months ago (2015-02-25 04:38:12 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 10 months ago (2015-02-25 04:58:31 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 04:59:02 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b570913b6d7a9254a43c576614c6d2de53df78e
Cr-Commit-Position: refs/heads/master@{#317975}

Powered by Google App Engine
This is Rietveld 408576698