scripts/slave/recipes/android/appurify.py - Issue 954743003: Make step status EXCEPTION when test runner has infrastructure failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/android/appurify.py

Issue 954743003: Make step status EXCEPTION when test runner has infrastructure failure. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Documented test_runner function arguments. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/chromium_android/config.py ('K') | « scripts/slave/recipe_modules/chromium_android/config.py ('k') | scripts/slave/recipes/android/appurify.expected/Android_Tests__amp__dbg__test_failure.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/android/appurify.py

diff --git a/scripts/slave/recipes/android/appurify.py b/scripts/slave/recipes/android/appurify.py

index b4123f11e9f5f7ada4c1546ca018d3428d3cc0ae..41e310c5d4eee884034b1c0d301590a8519d8121 100644

--- a/scripts/slave/recipes/android/appurify.py

+++ b/scripts/slave/recipes/android/appurify.py

@@ -96,6 +96,8 @@ AMP_INSTANCE_PROTOCOL = 'http'

AMP_RESULTS_BUCKET = 'chrome-amp-results'

def GenSteps(api):

+ api.amp.setup()

mastername = api.properties['mastername']

buildername = api.properties['buildername']

builder = BUILDERS[mastername][buildername]

@@ -253,7 +255,12 @@ def GenTests(api):

'targets': ['android_webview_unittests'],

'build_targets': ['android_webview_unittests_apk']})) +

api.step_data('[trigger] components_unittests', retcode=1) +

- api.step_data('[collect] android_webview_unittests', retcode=1)

+ # Test runner error

+ api.step_data('[collect] android_webview_unittests', retcode=1) +

+ # Test runner infrastructure error

+ api.step_data('[collect] base_unittests', retcode=87) +

+ # Test runner warning

+ api.step_data('[collect] cc_unittests', retcode=88)

)

yield (