Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: scripts/slave/recipes/android/appurify.py

Issue 954743003: Make step status EXCEPTION when test runner has infrastructure failure. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Moved exit code dict to test_runner function. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/android/appurify.py
diff --git a/scripts/slave/recipes/android/appurify.py b/scripts/slave/recipes/android/appurify.py
index b4123f11e9f5f7ada4c1546ca018d3428d3cc0ae..41e310c5d4eee884034b1c0d301590a8519d8121 100644
--- a/scripts/slave/recipes/android/appurify.py
+++ b/scripts/slave/recipes/android/appurify.py
@@ -96,6 +96,8 @@ AMP_INSTANCE_PROTOCOL = 'http'
AMP_RESULTS_BUCKET = 'chrome-amp-results'
def GenSteps(api):
+ api.amp.setup()
+
mastername = api.properties['mastername']
buildername = api.properties['buildername']
builder = BUILDERS[mastername][buildername]
@@ -253,7 +255,12 @@ def GenTests(api):
'targets': ['android_webview_unittests'],
'build_targets': ['android_webview_unittests_apk']})) +
api.step_data('[trigger] components_unittests', retcode=1) +
- api.step_data('[collect] android_webview_unittests', retcode=1)
+ # Test runner error
+ api.step_data('[collect] android_webview_unittests', retcode=1) +
+ # Test runner infrastructure error
+ api.step_data('[collect] base_unittests', retcode=87) +
+ # Test runner warning
+ api.step_data('[collect] cc_unittests', retcode=88)
)
yield (

Powered by Google App Engine
This is Rietveld 408576698