Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Side by Side Diff: scripts/slave/recipe_modules/chromium_android/config.py

Issue 954743003: Make step status EXCEPTION when test runner has infrastructure failure. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Documented test_runner function arguments. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import types 5 import types
6 6
7 from slave.recipe_config import config_item_context, ConfigGroup 7 from slave.recipe_config import config_item_context, ConfigGroup
8 from slave.recipe_config import ConfigList, Dict, List, Single, Static 8 from slave.recipe_config import ConfigList, Dict, List, Single, Static
9 from slave.recipe_config_types import Path 9 from slave.recipe_config_types import Path
10 10
(...skipping 11 matching lines...) Expand all
22 run_tree_truth = Single(bool, required=False, empty_val=True), 22 run_tree_truth = Single(bool, required=False, empty_val=True),
23 deps_file = Single(basestring, required=False, empty_val='.DEPS.git'), 23 deps_file = Single(basestring, required=False, empty_val='.DEPS.git'),
24 internal_dir_name = Single(basestring, required=False), 24 internal_dir_name = Single(basestring, required=False),
25 # deps_dir: where to checkout the gclient deps file 25 # deps_dir: where to checkout the gclient deps file
26 deps_dir = Single(basestring, required=False, empty_val=REPO_NAME), 26 deps_dir = Single(basestring, required=False, empty_val=REPO_NAME),
27 managed = Single(bool, required=False, empty_val=True), 27 managed = Single(bool, required=False, empty_val=True),
28 extra_deploy_opts = List(inner_type=basestring), 28 extra_deploy_opts = List(inner_type=basestring),
29 tests = List(inner_type=basestring), 29 tests = List(inner_type=basestring),
30 cr_build_android = Static(Path('[CHECKOUT]', 'build', 'android')), 30 cr_build_android = Static(Path('[CHECKOUT]', 'build', 'android')),
31 test_runner = Single(Path), 31 test_runner = Single(Path),
32 test_runner_exit_codes = Dict(value_type=int),
luqui 2015/03/02 23:40:58 This doesn't feel right to me. I would prefer to
mikecase (-- gone --) 2015/03/03 00:46:47 Done.
32 gclient_custom_deps = Dict(value_type=(basestring, types.NoneType)), 33 gclient_custom_deps = Dict(value_type=(basestring, types.NoneType)),
33 storage_bucket = Single(basestring), 34 storage_bucket = Single(basestring),
34 channel = Single(basestring, empty_val='chrome'), 35 channel = Single(basestring, empty_val='chrome'),
35 upload_dest_prefix = Single(basestring, empty_val=''), 36 upload_dest_prefix = Single(basestring, empty_val=''),
36 gclient_custom_vars = Dict(value_type=(basestring, types.NoneType)), 37 gclient_custom_vars = Dict(value_type=(basestring, types.NoneType)),
37 coverage = Single(bool, required=False, empty_val=False), 38 coverage = Single(bool, required=False, empty_val=False),
38 ) 39 )
39 40
40 41
41 VAR_TEST_MAP = { 42 VAR_TEST_MAP = {
42 'INTERNAL': [True, False], 43 'INTERNAL': [True, False],
43 'REPO_NAME': ['src/clank'], 44 'REPO_NAME': ['src/clank'],
44 'REPO_URL': ['<hidden>'], # supplied in build properties 45 'REPO_URL': ['<hidden>'], # supplied in build properties
45 'BUILD_CONFIG': ['Debug', 'Release'], 46 'BUILD_CONFIG': ['Debug', 'Release'],
46 } 47 }
47 48
48 def TEST_NAME_FORMAT(kwargs): # pragma: no cover 49 def TEST_NAME_FORMAT(kwargs): # pragma: no cover
49 name = 'repo-%(REPO_NAME)s-from-url-%(REPO_URL)s' % kwargs 50 name = 'repo-%(REPO_NAME)s-from-url-%(REPO_URL)s' % kwargs
50 if kwargs['INTERNAL']: 51 if kwargs['INTERNAL']:
51 return name + '-internal' 52 return name + '-internal'
52 else: 53 else:
53 return name 54 return name
54 55
55 config_ctx = config_item_context(BaseConfig, VAR_TEST_MAP, TEST_NAME_FORMAT) 56 config_ctx = config_item_context(BaseConfig, VAR_TEST_MAP, TEST_NAME_FORMAT)
56 57
57 @config_ctx(is_root=True) 58 @config_ctx(is_root=True)
58 def base_config(c): 59 def base_config(c):
59 c.internal_dir_name = 'clank' 60 c.internal_dir_name = 'clank'
60 c.test_runner = Path('[CHECKOUT]', 'build', 'android', 'test_runner.py') 61 c.test_runner = Path('[CHECKOUT]', 'build', 'android', 'test_runner.py')
62 c.test_runner_exit_codes = {'ERROR': 1, 'INFRA': 87, 'WARNING': 88}
61 63
62 @config_ctx() 64 @config_ctx()
63 def main_builder(c): 65 def main_builder(c):
64 pass 66 pass
65 67
66 @config_ctx() 68 @config_ctx()
67 def trybot_builder(c): 69 def trybot_builder(c):
68 pass 70 pass
69 71
70 @config_ctx() 72 @config_ctx()
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 def oilpan_builder(c): 201 def oilpan_builder(c):
200 pass 202 pass
201 203
202 @config_ctx() 204 @config_ctx()
203 def perf(c): 205 def perf(c):
204 pass 206 pass
205 207
206 @config_ctx() 208 @config_ctx()
207 def webview_perf(c): 209 def webview_perf(c):
208 pass 210 pass
OLDNEW
« no previous file with comments | « scripts/slave/recipe_modules/chromium_android/api.py ('k') | scripts/slave/recipes/android/appurify.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698