Source/bindings/scripts/v8_types.py - Issue 954723002: [bindings] Support is_explicit_nullable for method arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_types.py

Issue 954723002: [bindings] Support is_explicit_nullable for method arguments. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review comments addressed! Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_types.py

diff --git a/Source/bindings/scripts/v8_types.py b/Source/bindings/scripts/v8_types.py

index 27ef87e8000f25b536e3bbec4c32260b336da538..e7f8ad4f6a8c07809d1b94ec32e854bf8caf2f88 100644

--- a/Source/bindings/scripts/v8_types.py

+++ b/Source/bindings/scripts/v8_types.py

@@ -934,7 +934,7 @@ def cpp_type_has_null_value(idl_type):

# - 'Object' type. We use ScriptValue for object type.

return (idl_type.is_string_type or idl_type.is_interface_type or

idl_type.is_enum or idl_type.is_union_type

- or idl_type.base_type == 'object')

+ or idl_type.base_type == 'object' or idl_type.is_callback_interface)

IdlTypeBase.cpp_type_has_null_value = property(cpp_type_has_null_value)

« Source/bindings/scripts/v8_methods.py ('K') | « Source/bindings/scripts/v8_methods.py ('k') | Source/bindings/templates/methods.cpp » ('j') | Source/bindings/templates/methods.cpp » ('J')