Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: Source/bindings/scripts/v8_methods.py

Issue 954723002: [bindings] Support is_explicit_nullable for method arguments. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2013 Google Inc. All rights reserved. 1 # Copyright (C) 2013 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 'has_default': 'Default' in extended_attributes or set_default_value, 223 'has_default': 'Default' in extended_attributes or set_default_value,
224 'has_type_checking_interface': type_checking_interface, 224 'has_type_checking_interface': type_checking_interface,
225 # Dictionary is special-cased, but arrays and sequences shouldn't be 225 # Dictionary is special-cased, but arrays and sequences shouldn't be
226 'idl_type': idl_type.base_type, 226 'idl_type': idl_type.base_type,
227 'idl_type_object': idl_type, 227 'idl_type_object': idl_type,
228 'index': index, 228 'index': index,
229 'is_callback_function': idl_type.is_callback_function, 229 'is_callback_function': idl_type.is_callback_function,
230 'is_callback_interface': idl_type.is_callback_interface, 230 'is_callback_interface': idl_type.is_callback_interface,
231 # FIXME: Remove generic 'Dictionary' special-casing 231 # FIXME: Remove generic 'Dictionary' special-casing
232 'is_dictionary': idl_type.is_dictionary or idl_type.base_type == 'Dictio nary', 232 'is_dictionary': idl_type.is_dictionary or idl_type.base_type == 'Dictio nary',
233 'is_explicit_nullable': idl_type.is_explicit_nullable,
233 'is_nullable': idl_type.is_nullable, 234 'is_nullable': idl_type.is_nullable,
234 'is_optional': argument.is_optional, 235 'is_optional': argument.is_optional,
235 'is_variadic': argument.is_variadic, 236 'is_variadic': argument.is_variadic,
236 'is_variadic_wrapper_type': is_variadic_wrapper_type, 237 'is_variadic_wrapper_type': is_variadic_wrapper_type,
237 'is_wrapper_type': idl_type.is_wrapper_type, 238 'is_wrapper_type': idl_type.is_wrapper_type,
238 'name': argument.name, 239 'name': argument.name,
239 'private_script_cpp_value_to_v8_value': idl_type.cpp_value_to_v8_value( 240 'private_script_cpp_value_to_v8_value': idl_type.cpp_value_to_v8_value(
240 argument.name, isolate='scriptState->isolate()', 241 argument.name, isolate='scriptState->isolate()',
241 creation_context='scriptState->context()->Global()'), 242 creation_context='scriptState->context()->Global()'),
242 'use_permissive_dictionary_conversion': 'PermissiveDictionaryConversion' in extended_attributes, 243 'use_permissive_dictionary_conversion': 'PermissiveDictionaryConversion' in extended_attributes,
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
448 449
449 IdlOperation.returns_promise = property(method_returns_promise) 450 IdlOperation.returns_promise = property(method_returns_promise)
450 451
451 452
452 def argument_conversion_needs_exception_state(method, argument): 453 def argument_conversion_needs_exception_state(method, argument):
453 idl_type = argument.idl_type 454 idl_type = argument.idl_type
454 return (idl_type.v8_conversion_needs_exception_state or 455 return (idl_type.v8_conversion_needs_exception_state or
455 argument.is_variadic or 456 argument.is_variadic or
456 (method.returns_promise and (idl_type.is_string_type or 457 (method.returns_promise and (idl_type.is_string_type or
457 idl_type.is_enum))) 458 idl_type.is_enum)))
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/templates/methods.cpp » ('j') | Source/bindings/templates/methods.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698