Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 954693003: [strong] Make functions and generators non-extensible non-constructors (Closed)

Created:
5 years, 10 months ago by rossberg
Modified:
5 years, 10 months ago
CC:
v8-dev, Paweł Hajdan Jr., arv (Not doing code reviews), marja
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] Make functions and generators non-extensible non-constructors R=dslomov@chromium.org BUG= Committed: https://crrev.com/c094da92331f4a20abc0e3da6c7f64cfbfe1885f Cr-Commit-Position: refs/heads/master@{#26854}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -22 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 12 chunks +66 lines, -9 lines 0 comments Download
M src/contexts.h View 5 chunks +20 lines, -5 lines 0 comments Download
M test/mjsunit/strong/functions.js View 1 chunk +61 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
rossberg
5 years, 10 months ago (2015-02-24 15:07:05 UTC) #1
Dmitry Lomov (no reviews)
lgtm
5 years, 10 months ago (2015-02-24 18:20:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954693003/1
5 years, 10 months ago (2015-02-25 14:29:54 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 14:52:43 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 14:53:04 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c094da92331f4a20abc0e3da6c7f64cfbfe1885f
Cr-Commit-Position: refs/heads/master@{#26854}

Powered by Google App Engine
This is Rietveld 408576698