Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 954683002: InlinedVisitor: Migrate bindings to use inlined tracing (Closed)

Created:
5 years, 10 months ago by kouhei (in TOK)
Modified:
5 years, 10 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

InlinedVisitor: Migrate bindings to use inlined tracing Updates trace methods as of https://groups.google.com/a/chromium.org/d/msg/blink-dev/oi4Snt9jNx8/XcES55c7QaQJ R=oilpan-reviews BUG=455524 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190732

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -60 lines) Patch
M Source/bindings/core/v8/Iterable.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/Nullable.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/PageScriptDebugServer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/PageScriptDebugServer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/RejectedPromises.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/RejectedPromises.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/ScheduledAction.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScheduledAction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptDebugServer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptDebugServer.cpp View 1 chunk +1 line, -1 line 1 comment Download
M Source/bindings/core/v8/ScriptFunction.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptPromisePropertyBase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptPromisePropertyBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptPromiseResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptPromiseResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptSourceCode.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptSourceCode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptStreamer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptStreamer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptStreamerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ToV8Test.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8MutationCallback.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8MutationCallback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/WindowProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/WindowProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/WindowProxyManager.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/WindowProxyManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/WorkerScriptController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/WorkerScriptDebugServer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/WorkerScriptDebugServer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/custom/V8CustomXPathNSResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/custom/V8CustomXPathNSResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/callback_interface.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/callback_interface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/dictionary_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/dictionary_impl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/union.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/union.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/TestDictionary.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/TestDictionary.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/TestInterfaceEventInit.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/TestInterfaceEventInit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/TestPermissiveDictionary.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/TestPermissiveDictionary.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/UnionTypesCore.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/UnionTypesCore.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestCallbackInterface.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestCallbackInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
kouhei (in TOK)
5 years, 10 months ago (2015-02-24 07:50:34 UTC) #1
tkent
lgtm
5 years, 10 months ago (2015-02-24 08:07:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954683002/1
5 years, 10 months ago (2015-02-24 08:09:20 UTC) #5
haraken
LGTM https://codereview.chromium.org/954683002/diff/1/Source/bindings/core/v8/ScriptDebugServer.cpp File Source/bindings/core/v8/ScriptDebugServer.cpp (right): https://codereview.chromium.org/954683002/diff/1/Source/bindings/core/v8/ScriptDebugServer.cpp#newcode89 Source/bindings/core/v8/ScriptDebugServer.cpp:89: DEFINE_TRACE(ScriptDebugServer) You can inline this.
5 years, 10 months ago (2015-02-24 08:51:43 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 09:31:00 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190732

Powered by Google App Engine
This is Rietveld 408576698