Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 954663002: Enable ServiceWorkerPerfTest (service_worker.service_worker) (Closed)

Created:
5 years, 10 months ago by horo
Modified:
5 years, 10 months ago
Reviewers:
falken, nednguyen, sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable ServiceWorkerPerfTest (service_worker.service_worker) I think https://codereview.chromium.org/884573004/ fixed the ServiceWorker test flakiness. BUG=433943 TEST=./tools/perf/run_benchmark --browser-executable=~/chromium/src/out/Debug/chrome --also-run-disabled-tests service_worker.service_worker Committed: https://crrev.com/adaa44fc1275085c09fff18d8f2dfbddd88bc186 Cr-Commit-Position: refs/heads/master@{#317807}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M tools/perf/benchmarks/service_worker.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
horo
falken@ Could you please review?
5 years, 10 months ago (2015-02-24 05:50:17 UTC) #2
falken
On 2015/02/24 05:50:17, horo wrote: > falken@ > Could you please review? lgtm
5 years, 10 months ago (2015-02-24 05:56:10 UTC) #3
horo
nednguyen@ Could you please review this? Thank you.
5 years, 10 months ago (2015-02-24 06:02:15 UTC) #5
sullivan
lgtm Same as https://codereview.chromium.org/951223002/ - I am going to lgtm+cq so that it has time ...
5 years, 10 months ago (2015-02-24 14:10:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954663002/1
5 years, 10 months ago (2015-02-24 14:10:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 17:06:39 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/adaa44fc1275085c09fff18d8f2dfbddd88bc186 Cr-Commit-Position: refs/heads/master@{#317807}
5 years, 10 months ago (2015-02-24 17:07:12 UTC) #11
shatch
5 years, 10 months ago (2015-02-25 17:08:49 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/959793002/ by simonhatch@chromium.org.

The reason for reverting is: Failing on Nexus 10..

Powered by Google App Engine
This is Rietveld 408576698