Issue 954653002: Make Sky embedder.connection deal with null handles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 954653002: Make Sky embedder.connection deal with null handles (Closed)

Created:
5 years, 10 months ago by hansmuller

Modified:
5 years, 9 months ago

Reviewers:
hansmuller1, abarth-chromium

CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make Sky embedder.connection deal with null handles Also: gratuitous simplication of ApplicationConnection.requestService(). R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/cfaeb4a892e7ab1dbd9a9cd7a246fee4c9408540

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -11 lines)			Patch
	M	mojo/public/dart/src/application_connection.dart	View		1 chunk	+3 lines, -5 lines	0 comments	Download
	M	sky/framework/embedder.dart	View		1 chunk	+18 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

hansmuller

5 years, 9 months ago (2015-02-24 15:27:20 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cfaeb4a892e7ab1dbd9a9cd7a246fee4c9408540 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages