third_party/mojo_services/src/view_manager/public/cpp/lib/view_manager_client_factory.cc - Issue 954643002: Update mojo sdk to rev 3d23dae011859a2aae49f1d1adde705c8e85d819

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/mojo_services/src/view_manager/public/cpp/lib/view_manager_client_factory.cc

Issue 954643002: Update mojo sdk to rev 3d23dae011859a2aae49f1d1adde705c8e85d819 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use run_renderer_in_process() Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/mojo_services/src/view_manager/public/cpp/lib/view.cc ('k') | third_party/mojo_services/src/view_manager/public/cpp/lib/view_manager_client_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/mojo_services/src/view_manager/public/cpp/lib/view_manager_client_factory.cc

diff --git a/third_party/mojo_services/src/view_manager/public/cpp/lib/view_manager_client_factory.cc b/third_party/mojo_services/src/view_manager/public/cpp/lib/view_manager_client_factory.cc

index cfa2b79662c2b1f4210b169765487ab5b6015da6..bb39fc9d55a95bbeb8f9adb2f46482e8d79afcb0 100644

--- a/third_party/mojo_services/src/view_manager/public/cpp/lib/view_manager_client_factory.cc

+++ b/third_party/mojo_services/src/view_manager/public/cpp/lib/view_manager_client_factory.cc

@@ -19,17 +19,16 @@ ViewManagerClientFactory::~ViewManagerClientFactory() {

}

// static

-scoped_ptr<ViewManagerClient>

-ViewManagerClientFactory::WeakBindViewManagerToPipe(

+ViewManagerClient* ViewManagerClientFactory::WeakBindViewManagerToPipe(

InterfaceRequest<ViewManagerClient> request,

ViewManagerServicePtr view_manager_service,

Shell* shell,

ViewManagerDelegate* delegate) {

const bool delete_on_error = false;

- scoped_ptr<ViewManagerClientImpl> client(new ViewManagerClientImpl(

- delegate, shell, request.Pass(), delete_on_error));

+ auto client = new ViewManagerClientImpl(delegate, shell, request.Pass(),

+ delete_on_error);

client->SetViewManagerService(view_manager_service.Pass());

- return client.Pass();

+ return client;

}

// InterfaceFactory<ViewManagerClient> implementation.