Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: third_party/mojo_services/src/public/js/service_exchange.js

Issue 954643002: Update mojo sdk to rev 3d23dae011859a2aae49f1d1adde705c8e85d819 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use run_renderer_in_process() Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/mojo_services/src/public/js/service_exchange.js
diff --git a/third_party/mojo_services/src/public/js/service_exchange.js b/third_party/mojo_services/src/public/js/service_exchange.js
index a424c12f72516dfa3a8efa9c0ce53d92f83fe17f..f23c0ef018e335716f9a9e922efd3c6773d718fa 100644
--- a/third_party/mojo_services/src/public/js/service_exchange.js
+++ b/third_party/mojo_services/src/public/js/service_exchange.js
@@ -47,7 +47,7 @@ define("mojo/services/public/js/service_exchange", [
var provider = {
service: service, // A JS bindings interface object.
- factory: factory, // factory(clientProxy) => interface implemntation
+ factory: factory, // factory() => interface implemntation
connections: [],
};
this.providers_.set(service.name, provider);
@@ -60,12 +60,10 @@ define("mojo/services/public/js/service_exchange", [
}
// Outgoing requests
- requestService(interfaceObject, clientImpl) {
+ requestService(interfaceObject) {
checkServiceExchange(this);
if (!interfaceObject.name)
throw new Error("Invalid service parameter");
- if (!clientImpl && interfaceObject.client)
- throw new Error("Client implementation must be provided");
var serviceProxy;
var serviceHandle = connection.bindProxy(
« no previous file with comments | « third_party/mojo_services/src/public/js/application.js ('k') | third_party/mojo_services/src/public/js/shell.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698