Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/module.py

Issue 954643002: Update mojo sdk to rev 3d23dae011859a2aae49f1d1adde705c8e85d819 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use run_renderer_in_process() Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/module.py
diff --git a/third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/module.py b/third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/module.py
index c2e59a690048b8ccadf093572e4b72503b057e26..8d052d9de3f2c72aa345d0f7118676ad30ce6bda 100644
--- a/third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/module.py
+++ b/third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/module.py
@@ -131,7 +131,6 @@ PRIMITIVES = (
ATTRIBUTE_MIN_VERSION = 'MinVersion'
-ATTRIBUTE_CLIENT = 'Client'
class NamedValue(object):
@@ -271,16 +270,16 @@ class Map(ReferenceKind):
'm[' + key_kind.spec + '][' + value_kind.spec +
']')
if IsNullableKind(key_kind):
- raise Exception("Nullable kinds can not be keys in maps.")
+ raise Exception("Nullable kinds cannot be keys in maps.")
if IsStructKind(key_kind):
# TODO(erg): It would sometimes be nice if we could key on struct
# values. However, what happens if the struct has a handle in it? Or
# non-copyable data like an array?
- raise Exception("Structs can not be keys in maps.")
+ raise Exception("Structs cannot be keys in maps.")
if IsAnyHandleKind(key_kind):
- raise Exception("Handles can not be keys in maps.")
+ raise Exception("Handles cannot be keys in maps.")
if IsArrayKind(key_kind):
- raise Exception("Arrays can not be keys in maps.")
+ raise Exception("Arrays cannot be keys in maps.")
else:
ReferenceKind.__init__(self)
@@ -370,9 +369,10 @@ class Interface(ReferenceKind):
self.methods.append(method)
return method
+ # TODO(451323): Remove when the language backends no longer rely on this.
@property
def client(self):
- return self.attributes.get(ATTRIBUTE_CLIENT) if self.attributes else None
+ return None
class EnumField(object):

Powered by Google App Engine
This is Rietveld 408576698