third_party/mojo/src/mojo/public/cpp/bindings/lib/validation_errors.h - Issue 954643002: Update mojo sdk to rev 3d23dae011859a2aae49f1d1adde705c8e85d819

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/mojo/src/mojo/public/cpp/bindings/lib/validation_errors.h

Issue 954643002: Update mojo sdk to rev 3d23dae011859a2aae49f1d1adde705c8e85d819 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use run_renderer_in_process() Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/mojo/src/mojo/public/cpp/bindings/lib/message_header_validator.cc ('k') | third_party/mojo/src/mojo/public/cpp/bindings/map.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/mojo/src/mojo/public/cpp/bindings/lib/validation_errors.h

diff --git a/third_party/mojo/src/mojo/public/cpp/bindings/lib/validation_errors.h b/third_party/mojo/src/mojo/public/cpp/bindings/lib/validation_errors.h

index 4facf6e809c9d557a360336a5a0a9c497585885e..fbba6b30488913dcd9d5f09e16066835970748fd 100644

--- a/third_party/mojo/src/mojo/public/cpp/bindings/lib/validation_errors.h

+++ b/third_party/mojo/src/mojo/public/cpp/bindings/lib/validation_errors.h

@@ -19,11 +19,11 @@ enum ValidationError {

// objects.

VALIDATION_ERROR_ILLEGAL_MEMORY_RANGE,

// A struct header doesn't make sense, for example:

- // - |num_bytes| is smaller than the size of the oldest version that we

- // support.

- // - |num_fields| is smaller than the field number of the oldest version that

- // we support.

- // - |num_bytes| and |num_fields| don't match.

+ // - |num_bytes| is smaller than the size of the struct header.

+ // - |num_bytes| and |version| don't match.

+ // TODO(yzshen): Consider splitting it into two different error codes. Because

+ // the former indicates someone is misbehaving badly whereas the latter could

+ // be due to an inappropriately-modified .mojom file.

VALIDATION_ERROR_UNEXPECTED_STRUCT_HEADER,

// An array header doesn't make sense, for example:

// - |num_bytes| is smaller than the size of the header plus the size required