Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: third_party/mojo/src/mojo/public/cpp/bindings/interface_ptr.h

Issue 954643002: Update mojo sdk to rev 3d23dae011859a2aae49f1d1adde705c8e85d819 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use run_renderer_in_process() Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/mojo/src/mojo/public/cpp/bindings/interface_ptr.h
diff --git a/third_party/mojo/src/mojo/public/cpp/bindings/interface_ptr.h b/third_party/mojo/src/mojo/public/cpp/bindings/interface_ptr.h
index b7f1a4e93c823787802630a8b433face7c10a069..8b5e0b4a91dd90528d36f7321f4b01b9645b43e1 100644
--- a/third_party/mojo/src/mojo/public/cpp/bindings/interface_ptr.h
+++ b/third_party/mojo/src/mojo/public/cpp/bindings/interface_ptr.h
@@ -20,11 +20,6 @@ class ErrorHandler;
// closes the pipe and deletes the proxy on destruction. The pointer must be
// bound to a message pipe before the interface methods can be called.
//
-// Can also route incoming calls to a local implementation of the
-// Interface::Client interface. To enable this, call the set_client() method.
-// Calls to the client interface will originate from the same thread that owns
-// this InterfacePtr.
-//
// This class is thread hostile, as is the local proxy it manages. All calls to
// this class or the proxy should be from the same thread that created it. If
// you need to move the proxy to a different thread, extract the message pipe
@@ -87,23 +82,18 @@ class InterfacePtr {
internal_state_.Swap(&doomed);
}
- // Blocks the current thread until the next incoming call to a client method
- // or callback arrives, or until an error occurs. Returns |true| if a call
- // arrived, or |false| in case of error.
+ // Blocks the current thread until the next incoming response callback arrives
+ // or an error occurs. Returns |true| if a response arrived, or |false| in
+ // case of error.
//
// This method may only be called after the InterfacePtr has been bound to a
// message pipe.
+ //
+ // TODO(jamesr): Rename to WaitForIncomingResponse().
bool WaitForIncomingMethodCall() {
return internal_state_.WaitForIncomingMethodCall();
}
- // Enables routing of incoming method calls to a local implementation of the
- // Interface::Client interface. Calls to |client| will come from the thread
- // that owns this InterfacePtr.
- void set_client(typename Interface::Client* client) {
- internal_state_.set_client(client);
- }
-
// Indicates whether the message pipe has encountered an error. If true,
// method calls made on this interface will be dropped (and may already have
// been dropped).

Powered by Google App Engine
This is Rietveld 408576698