Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: third_party/mojo/src/mojo/edk/system/connection_manager.h

Issue 954643002: Update mojo sdk to rev 3d23dae011859a2aae49f1d1adde705c8e85d819 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use run_renderer_in_process() Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/mojo/src/mojo/edk/system/connection_manager.h
diff --git a/third_party/mojo/src/mojo/edk/system/connection_manager.h b/third_party/mojo/src/mojo/edk/system/connection_manager.h
index fede7a54bc5c14950b6f4731644694412859d889..921d19c5561f3ffec9600939904761ba579fce6f 100644
--- a/third_party/mojo/src/mojo/edk/system/connection_manager.h
+++ b/third_party/mojo/src/mojo/edk/system/connection_manager.h
@@ -6,6 +6,7 @@
#define MOJO_EDK_SYSTEM_CONNECTION_MANAGER_H_
#include "base/macros.h"
+#include "mojo/edk/system/system_impl_export.h"
#include "mojo/edk/system/unique_identifier.h"
namespace mojo {
@@ -62,15 +63,21 @@ const ProcessIdentifier kInvalidProcessIdentifier = 0;
// connected to the master by a special dedicated |RawChannel|, on which it does
// synchronous IPC (note, however, that the master should never block on any
// slave).
-class ConnectionManager {
+class MOJO_SYSTEM_IMPL_EXPORT ConnectionManager {
public:
- // All of these methods return true on success or false on failure. Failure is
- // obviously fatal for the establishment of a particular connection, but
- // should not be treated as fatal to the process. Failure may, e.g., be caused
- // by a misbehaving (malicious) untrusted peer process.
+ virtual ~ConnectionManager() {}
+
+ // Shuts down this connection manager. No other methods may be called after
+ // this is (or while it is being) called.
+ virtual void Shutdown() = 0;
// TODO(vtl): Add a "get my own process identifier" method?
+ // All of the methods below return true on success or false on failure.
+ // Failure is obviously fatal for the establishment of a particular
+ // connection, but should not be treated as fatal to the process. Failure may,
+ // e.g., be caused by a misbehaving (malicious) untrusted peer process.
+
// Allows a process who makes the identical call (with equal |connection_id|)
// to connect to the calling process. (On success, there will be a "pending
// connection" for the given |connection_id| for the calling process.)
@@ -93,7 +100,6 @@ class ConnectionManager {
protected:
ConnectionManager() {}
- virtual ~ConnectionManager() {}
private:
DISALLOW_COPY_AND_ASSIGN(ConnectionManager);

Powered by Google App Engine
This is Rietveld 408576698