Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issue 954603003: Update font for unicode-variation-selector.html (Closed)

Created:
5 years, 10 months ago by bashi
Modified:
5 years, 10 months ago
Reviewers:
Kunihiko Sakamoto
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Update font for unicode-variation-selector.html OTS rejects gw432047.ttf because the font is broken. We should not use it. Instead, use a variant of the Ahem-font which has a variation selector for 'a'. When a variation selector U+E0100 follows 'a', the glyph for 'a' should be the same glyph as 'p' (which is a 0.2em height rectangle) on platforms which support IVS (Note that we don't support IVS yet on some platforms). I use a script[1] to create this font. [1] https://gist.github.com/bashi/1048e2e84394723fdc65 BUG=461128 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190743

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : TestExpectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -18 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/fast/loader/resource-request-callbacks.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/text/resources/AhemIVS.ttf View Binary file 0 comments Download
D LayoutTests/fast/text/resources/gw432047.ttf View Binary file 0 comments Download
D LayoutTests/fast/text/resources/gw432047-license.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M LayoutTests/fast/text/unicode-variation-selector.html View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
bashi
PTAL?
5 years, 10 months ago (2015-02-24 02:22:14 UTC) #2
Kunihiko Sakamoto
Looks like we need NeedsRebaseline for virtual tests too?
5 years, 10 months ago (2015-02-24 03:30:16 UTC) #3
bashi
On 2015/02/24 03:30:16, Kunihiko Sakamoto wrote: > Looks like we need NeedsRebaseline for virtual tests ...
5 years, 10 months ago (2015-02-24 06:53:19 UTC) #4
Kunihiko Sakamoto
LGTM Thanks for doing this!
5 years, 10 months ago (2015-02-24 06:57:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954603003/40001
5 years, 10 months ago (2015-02-24 10:54:31 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 11:02:17 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190743

Powered by Google App Engine
This is Rietveld 408576698