Support detaching/attaching panels via inter-strip drags.

chrome/browser/ui/panels/panel_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/download/download_service.h"
 #include "chrome/browser/download/download_service_factory.h"
 #include "chrome/browser/net/url_request_mock_util.h"
@@ skipping 441 matching lines @@
   // FindBar needs tab contents.
   CreateTestTabContents(browser);
   browser->ShowFindBar();
   ASSERT_TRUE(browser->GetFindBarController()->find_bar()->IsFindBarVisible());
   panel->Close();
 }
 
 IN_PROC_BROWSER_TEST_F(PanelBrowserTest, DragOnePanel) {
   static const int num_panels = 1;
   static const int zero_delta = 0;
-  static const int big_delta = 70;
+  static const int big_delta_x = 70;
+  static const int big_delta_y = 30;  // Do not exceed the threshold to detach.
 
   static const std::vector<int> zero_deltas(num_panels, zero_delta);
   std::vector<int> expected_delta_x_after_drag(num_panels, zero_delta);
   std::vector<int> expected_delta_x_after_finish(num_panels, zero_delta);
 
   Panel* panel1 =
       CreatePanelWithBounds("PanelTest1", gfx::Rect(0, 0, 100, 100));
 
   // Drag left.
-  expected_delta_x_after_drag[0] = -big_delta;
+  expected_delta_x_after_drag[0] = -big_delta_x;
   expected_delta_x_after_finish = zero_deltas;
-  TestDragging(-big_delta, zero_delta, 0, expected_delta_x_after_drag,
+  TestDragging(-big_delta_x, zero_delta, 0, expected_delta_x_after_drag,
                zero_deltas, GetAllPanelBounds(),
                DRAG_ACTION_BEGIN | DRAG_ACTION_FINISH);
 
   // Drag left and cancel.
-  expected_delta_x_after_drag[0] = -big_delta;
+  expected_delta_x_after_drag[0] = -big_delta_x;
   expected_delta_x_after_finish = zero_deltas;
-  TestDragging(-big_delta, zero_delta, 0, expected_delta_x_after_drag,
+  TestDragging(-big_delta_x, zero_delta, 0, expected_delta_x_after_drag,
                zero_deltas, GetAllPanelBounds(),
                DRAG_ACTION_BEGIN | DRAG_ACTION_CANCEL);
 
   // Drag right.
-  expected_delta_x_after_drag[0] = big_delta;
-  TestDragging(big_delta, zero_delta, 0, expected_delta_x_after_drag,
+  expected_delta_x_after_drag[0] = big_delta_x;
+  TestDragging(big_delta_x, zero_delta, 0, expected_delta_x_after_drag,
                zero_deltas, GetAllPanelBounds(),
                DRAG_ACTION_BEGIN | DRAG_ACTION_FINISH);
 
   // Drag right and up.  Expect no vertical movement.
-  TestDragging(big_delta, big_delta, 0, expected_delta_x_after_drag,
+  TestDragging(big_delta_x, big_delta_y, 0, expected_delta_x_after_drag,
                zero_deltas, GetAllPanelBounds(),
                DRAG_ACTION_BEGIN | DRAG_ACTION_FINISH);
 
   // Drag up.  Expect no movement on drag.
-  TestDragging(0, -big_delta, 0, zero_deltas, zero_deltas,
+  TestDragging(0, -big_delta_y, 0, zero_deltas, zero_deltas,
                GetAllPanelBounds(), DRAG_ACTION_BEGIN | DRAG_ACTION_FINISH);
 
   // Drag down.  Expect no movement on drag.
-  TestDragging(0, big_delta, 0, zero_deltas, zero_deltas,
+  TestDragging(0, big_delta_y, 0, zero_deltas, zero_deltas,
                GetAllPanelBounds(), DRAG_ACTION_BEGIN | DRAG_ACTION_FINISH);
 
   panel1->Close();
 }
 
 IN_PROC_BROWSER_TEST_F(PanelBrowserTest, DragTwoPanels) {
   static const int num_panels = 2;
   static const int zero_delta = 0;
   static const int small_delta = 10;
   static const int big_delta = 70;
@@ skipping 1679 matching lines @@
   // position when tall panel brings up its titlebar.
   CloseWindowAndWait(panel1->browser());
   EXPECT_EQ(balloon_bottom_after_tall_panel_titlebar_up,
             GetBalloonBottomPosition(balloon));
 
   // Closing the remaining tall panel should move the notification balloon back
   // to its original position.
   CloseWindowAndWait(panel2->browser());
   EXPECT_EQ(original_balloon_bottom, GetBalloonBottomPosition(balloon));
 }