Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: ui/file_manager/file_manager/foreground/js/file_manager.js

Issue 954583004: Shrink space required by history log file (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/file_manager.js
diff --git a/ui/file_manager/file_manager/foreground/js/file_manager.js b/ui/file_manager/file_manager/foreground/js/file_manager.js
index a5de1582b9979887c41fe4d562778a8c4616e294..56320d4209c82244bebe0390c358f38cf9b1238f 100644
--- a/ui/file_manager/file_manager/foreground/js/file_manager.js
+++ b/ui/file_manager/file_manager/foreground/js/file_manager.js
@@ -807,6 +807,10 @@ FileManager.prototype = /** @struct */ {
FileManager.prototype.onHistoryChanged_ = function(event) {
this.tracker_.send(metrics.ImportEvents.HISTORY_CHANGED);
+ if (!event.entry) {
mtomasz 2015/02/25 00:40:17 nit: Can we add a comment when can it happen that
Steve McKay 2015/02/25 01:51:56 Actually it should never be null. I might have add
+ return;
+ }
+
// Ignore any entry that isn't an immediate child of the
// current directory.
util.isChildEntry(event.entry, this.getCurrentDirectoryEntry())

Powered by Google App Engine
This is Rietveld 408576698