Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: extensions/renderer/resources/guest_view/web_view_events.js

Issue 954543002: <webview>: Fix SrcAttribute and Cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/resources/guest_view/web_view_attributes.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/resources/guest_view/web_view_events.js
diff --git a/extensions/renderer/resources/guest_view/web_view_events.js b/extensions/renderer/resources/guest_view/web_view_events.js
index 16da1cafa14298add5b3a29bc4fb28cce68e9e5e..98549df480631cf155f92aa6c345fa33c6f9a880 100644
--- a/extensions/renderer/resources/guest_view/web_view_events.js
+++ b/extensions/renderer/resources/guest_view/web_view_events.js
@@ -182,6 +182,9 @@ function WebViewEvents(webViewImpl, viewInstanceId) {
this.webViewImpl = webViewImpl;
this.viewInstanceId = viewInstanceId;
+ // on* Event handlers.
+ this.on = {};
+
// Set up the events.
this.setupFrameNameChangedEvent();
this.setupWebRequestEvents();
@@ -290,7 +293,26 @@ WebViewEvents.prototype.setupEvent = function(name, info) {
this.webViewImpl.dispatchEvent(webViewEvent);
}.bind(this), {instanceId: this.viewInstanceId});
- this.webViewImpl.setupEventProperty(name);
+ this.setupEventProperty(name);
+};
+
+WebViewEvents.prototype.setupEventProperty = function(eventName) {
+ var propertyName = 'on' + eventName.toLowerCase();
+ Object.defineProperty(this.webViewImpl.element, propertyName, {
+ get: function() {
+ return this.on[propertyName];
+ }.bind(this),
+ set: function(value) {
+ if (this.on[propertyName]) {
+ this.webViewImpl.element.removeEventListener(
+ eventName, this.on[propertyName]);
+ }
+ this.on[propertyName] = value;
+ if (value)
+ this.webViewImpl.element.addEventListener(eventName, value);
+ }.bind(this),
+ enumerable: true
+ });
};
WebViewEvents.prototype.handleDialogEvent = function(event, webViewEvent) {
@@ -310,9 +332,11 @@ WebViewEvents.prototype.handleLoadAbortEvent = function(event, webViewEvent) {
WebViewEvents.prototype.handleLoadCommitEvent = function(event, webViewEvent) {
this.webViewImpl.onLoadCommit(event.baseUrlForDataUrl,
- event.currentEntryIndex, event.entryCount,
- event.processId, event.url,
- event.isTopLevel);
+ event.currentEntryIndex,
+ event.entryCount,
+ event.processId,
+ event.url,
+ event.isTopLevel);
this.webViewImpl.dispatchEvent(webViewEvent);
};
« no previous file with comments | « extensions/renderer/resources/guest_view/web_view_attributes.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698