<webview>: Fix SrcAttribute and Cleanup

extensions/renderer/resources/guest_view/web_view_events.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Event management for WebView.
 
 var DeclarativeWebRequestSchema =
     requireNative('schema_registry').GetSchema('declarativeWebRequest');
 var EventBindings = require('event_bindings');
 var IdGenerator = requireNative('id_generator');
@@ skipping 164 matching lines @@
 
 DeclarativeWebRequestEvent.prototype = {
   __proto__: EventBindings.Event.prototype
 };
 
 // Constructor.
 function WebViewEvents(webViewImpl, viewInstanceId) {
   this.webViewImpl = webViewImpl;
   this.viewInstanceId = viewInstanceId;
 
+  // on* Event handlers.
+  this.on = {};
+
   // Set up the events.
   this.setupFrameNameChangedEvent();
   this.setupWebRequestEvents();
   this.webViewImpl.setupExperimentalContextMenus();
   var events = this.getEvents();
   for (var eventName in events) {
     this.setupEvent(eventName, events[eventName]);
   }
 }
 
@@ skipping 88 matching lines @@
         webViewEvent[field] = e[field];
       }
     }.bind(this));
     if (info.customHandler) {
       info.customHandler(this, e, webViewEvent);
       return;
     }
     this.webViewImpl.dispatchEvent(webViewEvent);
   }.bind(this), {instanceId: this.viewInstanceId});
 
-  this.webViewImpl.setupEventProperty(name);
+  this.setupEventProperty(name);
+};
+
+WebViewEvents.prototype.setupEventProperty = function(eventName) {
+  var propertyName = 'on' + eventName.toLowerCase();
+  Object.defineProperty(this.webViewImpl.element, propertyName, {
+    get: function() {
+      return this.on[propertyName];
+    }.bind(this),
+    set: function(value) {
+      if (this.on[propertyName]) {
+        this.webViewImpl.element.removeEventListener(
+            eventName, this.on[propertyName]);
+      }
+      this.on[propertyName] = value;
+      if (value)
+        this.webViewImpl.element.addEventListener(eventName, value);
+    }.bind(this),
+    enumerable: true
+  });
 };
 
 WebViewEvents.prototype.handleDialogEvent = function(event, webViewEvent) {
   new WebViewActionRequests.Dialog(this.webViewImpl, event, webViewEvent);
 };
 
 WebViewEvents.prototype.handleLoadAbortEvent = function(event, webViewEvent) {
   var showWarningMessage = function(reason) {
     var WARNING_MSG_LOAD_ABORTED = '<webview>: ' +
         'The load has aborted with reason "%1".';
     window.console.warn(WARNING_MSG_LOAD_ABORTED.replace('%1', reason));
   };
   if (this.webViewImpl.dispatchEvent(webViewEvent)) {
     showWarningMessage(event.reason);
   }
 };
 
 WebViewEvents.prototype.handleLoadCommitEvent = function(event, webViewEvent) {
   this.webViewImpl.onLoadCommit(event.baseUrlForDataUrl,
-                                    event.currentEntryIndex, event.entryCount,
-                                    event.processId, event.url,
-                                    event.isTopLevel);
+                                event.currentEntryIndex,
+                                event.entryCount,
+                                event.processId,
+                                event.url,
+                                event.isTopLevel);
   this.webViewImpl.dispatchEvent(webViewEvent);
 };
 
 WebViewEvents.prototype.handleNewWindowEvent = function(event, webViewEvent) {
   new WebViewActionRequests.NewWindow(this.webViewImpl, event, webViewEvent);
 };
 
 WebViewEvents.prototype.handlePermissionEvent = function(event, webViewEvent) {
   new WebViewActionRequests.PermissionRequest(
       this.webViewImpl, event, webViewEvent);
 };
 
 WebViewEvents.prototype.handleSizeChangedEvent = function(
     event, webViewEvent) {
   this.webViewImpl.onSizeChanged(webViewEvent);
 };
 
 exports.WebViewEvents = WebViewEvents;
 exports.CreateEvent = CreateEvent;