<webview>: Fix SrcAttribute and Cleanup

extensions/renderer/resources/guest_view/web_view_attributes.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This module implements the attributes of the <webview> tag.
 
 var GuestViewInternal =
     require('binding').Binding.create('guestViewInternal').generate();
 var WebViewImpl = require('webView').WebViewImpl;
 var WebViewConstants = require('webViewConstants').WebViewConstants;
@@ skipping 166 matching lines @@
 NameAttribute.prototype.handleMutation = function(oldValue, newValue) {
   oldValue = oldValue || '';
   newValue = newValue || '';
   if (oldValue === newValue || !this.webViewImpl.guest.getId()) {
     return;
   }
 
   WebViewInternal.setName(this.webViewImpl.guest.getId(), newValue);
 };
 
+NameAttribute.prototype.setValue = function(value) {
+  value = value || '';
+  if (value === '') {
+    this.webViewImpl.element.removeAttribute(this.name);
+  } else {
+    this.webViewImpl.element.setAttribute(this.name, value);
+  }
+};
+
 // Attribute representing the state of the storage partition.
 function PartitionAttribute(webViewImpl) {
   WebViewAttribute.call(
       this, WebViewConstants.ATTRIBUTE_PARTITION, webViewImpl);
   this.validPartitionId = true;
 }
 
 PartitionAttribute.prototype.__proto__ = WebViewAttribute.prototype;
 
 PartitionAttribute.prototype.handleMutation = function(oldValue, newValue) {
@@ skipping 20 matching lines @@
 // Attribute that handles the location and navigation of the webview.
 function SrcAttribute(webViewImpl) {
   WebViewAttribute.call(this, WebViewConstants.ATTRIBUTE_SRC, webViewImpl);
   this.setupMutationObserver();
   this.beforeFirstNavigation = true;
 }
 
 SrcAttribute.prototype.__proto__ = WebViewAttribute.prototype;
 
 SrcAttribute.prototype.setValueIgnoreMutation = function(value) {
+  WebViewAttribute.prototype.setValueIgnoreMutation.call(this, value);
   // takeRecords() is needed to clear queued up src mutations. Without it, it is
   // possible for this change to get picked up asyncronously by src's mutation
   // observer |observer|, and then get handled even though we do not want to
   // handle this mutation.
   this.observer.takeRecords();
-  WebViewAttribute.prototype.setValueIgnoreMutation.call(this, value);
 }
 
 SrcAttribute.prototype.handleMutation = function(oldValue, newValue) {
   // Once we have navigated, we don't allow clearing the src attribute.
   // Once <webview> enters a navigated state, it cannot return to a
   // placeholder state.
   if (!newValue && oldValue) {
     // src attribute changes normally initiate a navigation. We suppress
     // the next src attribute handler call to avoid reloading the page
     // on every guest-initiated navigation.
@@ skipping 72 matching lines @@
 
   var autosizeAttributes = [WebViewConstants.ATTRIBUTE_MAXHEIGHT,
                             WebViewConstants.ATTRIBUTE_MAXWIDTH,
                             WebViewConstants.ATTRIBUTE_MINHEIGHT,
                             WebViewConstants.ATTRIBUTE_MINWIDTH];
   for (var i = 0; autosizeAttributes[i]; ++i) {
     this.attributes[autosizeAttributes[i]] =
         new AutosizeDimensionAttribute(autosizeAttributes[i], this);
   }
 };