<webview>: Fix SrcAttribute and Cleanup

extensions/renderer/resources/guest_view/web_view.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This module implements WebView (<webview>) as a custom element that wraps a
 // BrowserPlugin object element. The object element is hidden within
 // the shadow DOM of the WebView element.
 
 var DocumentNatives = requireNative('document_natives');
 var GuestView = require('guestView').GuestView;
 var GuestViewContainer = require('guestViewContainer').GuestViewContainer;
 var WebViewConstants = require('webViewConstants').WebViewConstants;
 var WebViewEvents = require('webViewEvents').WebViewEvents;
 var WebViewInternal = require('webViewInternal').WebViewInternal;
 
 // Represents the internal state of <webview>.
 function WebViewImpl(webviewElement) {
   GuestViewContainer.call(this, webviewElement, 'webview');
 
   this.setupWebViewAttributes();
   this.setupElementProperties();
 
-  // on* Event handlers.
-  this.on = {};
   new WebViewEvents(this, this.viewInstanceId);
 }
 
 WebViewImpl.prototype.__proto__ = GuestViewContainer.prototype;
 
 WebViewImpl.VIEW_TYPE = 'WebView';
 
 // Add extra functionality to |this.element|.
 WebViewImpl.setupElement = function(proto) {
   // Public-facing API methods.
@@ skipping 114 matching lines @@
   }
 };
 
 WebViewImpl.prototype.createGuest = function() {
   this.guest.create(this.buildParams(), function() {
     this.attachWindow();
   }.bind(this));
 };
 
 WebViewImpl.prototype.onFrameNameChanged = function(name) {
-  name = name || '';
-  if (name === '') {
-    this.element.removeAttribute(WebViewConstants.ATTRIBUTE_NAME);
-  } else {
-    this.attributes[WebViewConstants.ATTRIBUTE_NAME].setValue(name);
-  }
+  this.attributes[WebViewConstants.ATTRIBUTE_NAME].setValueIgnoreMutation(name);
 };
 
 WebViewImpl.prototype.dispatchEvent = function(webViewEvent) {
   return this.element.dispatchEvent(webViewEvent);
 };
 
-// Adds an 'on<event>' property on the webview, which can be used to set/unset
-// an event handler.
-WebViewImpl.prototype.setupEventProperty = function(eventName) {
-  var propertyName = 'on' + eventName.toLowerCase();
-  Object.defineProperty(this.element, propertyName, {
-    get: function() {
-      return this.on[propertyName];
-    }.bind(this),
-    set: function(value) {
-      if (this.on[propertyName])
-        this.element.removeEventListener(eventName, this.on[propertyName]);
-      this.on[propertyName] = value;
-      if (value)
-        this.element.addEventListener(eventName, value);
-    }.bind(this),
-    enumerable: true
-  });
-};
-
 // Updates state upon loadcommit.
 WebViewImpl.prototype.onLoadCommit = function(
     baseUrlForDataUrl, currentEntryIndex, entryCount,
     processId, url, isTopLevel) {
   this.baseUrlForDataUrl = baseUrlForDataUrl;
   this.currentEntryIndex = currentEntryIndex;
   this.entryCount = entryCount;
   this.processId = processId;
-  var oldValue = this.attributes[WebViewConstants.ATTRIBUTE_SRC].getValue();
-  var newValue = url;
-  if (isTopLevel && (oldValue != newValue)) {
+  if (isTopLevel) {
     // Touching the src attribute triggers a navigation. To avoid
     // triggering a page reload on every guest-initiated navigation,
     // we do not handle this mutation.
-    this.attributes[WebViewConstants.ATTRIBUTE_SRC].setValueIgnoreMutation(
-        newValue);
+    this.attributes[
+        WebViewConstants.ATTRIBUTE_SRC].setValueIgnoreMutation(url);
   }
 };
 
 WebViewImpl.prototype.onAttach = function(storagePartitionId) {
-  this.attributes[WebViewConstants.ATTRIBUTE_PARTITION].setValue(
+  this.attributes[WebViewConstants.ATTRIBUTE_PARTITION].setValueIgnoreMutation(
       storagePartitionId);
 };
 
 WebViewImpl.prototype.buildContainerParams = function() {
   var params = { 'userAgentOverride': this.userAgentOverride };
   for (var i in this.attributes) {
     params[i] = this.attributes[i].getValue();
   }
   return params;
 };
@@ skipping 38 matching lines @@
 WebViewImpl.prototype.setupExperimentalContextMenus = function() {};
 WebViewImpl.prototype.maybeSetupExperimentalChromeWebViewEvents =
   function(request) {
     return request;
 };
 
 GuestViewContainer.registerElement(WebViewImpl);
 
 // Exports.
 exports.WebViewImpl = WebViewImpl;