Description<webview>: Fix SrcAttribute and Cleanup
SrcAttribute.setValueIgnoreMutation was calling takeRecords() prior to applying the operation,
which meant it didn't actually do the right thing. Mutation callbacks would still get queued
up by the mutation observer. This wasn't noticed because WebViewImpl.onLoadCommit only called
setValueIgnoreMutation if there was a change in value, and so the mutation observer would not
trigger any mutations. This CL fixes this issue and simplifies the code in WebViewImpl.onLoadCommit
a bit.
This CL moves setting NameAttribute details from WebViewImpl and into the NameAttribute object.
This CL also fixes some attribute changes to make sure their mutation handlers don't fire.
Finally, this CL moves setupEventProperty to web_view_events.js where it makes more sense to be.
BUG=none
TBR=lazyboy@chromium.org
Committed: https://crrev.com/cab37f85ed91c494e86fc201bf1550b9ba467471
Cr-Commit-Position: refs/heads/master@{#317682}
Patch Set 1 #
Messages
Total messages: 13 (6 generated)
|