Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 954523004: Add testing section of docs (Closed)

Created:
5 years, 10 months ago by hcm
Modified:
5 years, 9 months ago
Reviewers:
jcgregorio, borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add testing section of docs. Consolidated trybot/buildbot section BUG=skia: Preview link: http://skiadocs.com:8000/dev/testing/?cl=954523004 Committed: https://skia.googlesource.com/skia/+/281bf5249c2930ff4e8a500c8c26deb8e3253b11

Patch Set 1 #

Patch Set 2 : correct link, formatting #

Patch Set 3 : bullet formatting #

Patch Set 4 : move files under testing section, formatting #

Total comments: 7

Patch Set 5 : updated buildbot page #

Patch Set 6 : minor formatting #

Total comments: 4

Patch Set 7 : remove content, update build description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -244 lines) Patch
D site/dev/contrib/testing.md View 1 2 3 1 chunk +0 lines, -181 lines 0 comments Download
D site/dev/contrib/tests.md View 1 2 3 1 chunk +0 lines, -65 lines 0 comments Download
A site/dev/testing/buildbot.md View 1 2 3 4 5 6 1 chunk +70 lines, -0 lines 0 comments Download
A site/dev/testing/fonts.md View 1 2 3 1 chunk +118 lines, -0 lines 0 comments Download
A site/dev/testing/index.md View 1 1 chunk +16 lines, -0 lines 0 comments Download
A + site/dev/testing/testing.md View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + site/dev/testing/tests.md View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
hcm
On 2015/02/24 05:59:50, hcm wrote: > mailto:hcm@google.com changed reviewers: > + mailto:borenet@google.com, mailto:jcgregorio@google.com Please give ...
5 years, 10 months ago (2015-02-24 06:17:35 UTC) #2
borenet
Lots of comments on the buildbot section. If you'd prefer, I can rewrite that part, ...
5 years, 10 months ago (2015-02-24 14:13:46 UTC) #3
hcm
On 2015/02/24 14:13:46, borenet wrote: > Lots of comments on the buildbot section. If you'd ...
5 years, 10 months ago (2015-02-25 18:16:35 UTC) #4
borenet
Looks good! Just a couple of minor comments. https://codereview.chromium.org/954523004/diff/100001/site/dev/testing/buildbot.md File site/dev/testing/buildbot.md (right): https://codereview.chromium.org/954523004/diff/100001/site/dev/testing/buildbot.md#newcode52 site/dev/testing/buildbot.md:52: revision ...
5 years, 10 months ago (2015-02-25 18:25:23 UTC) #5
hcm
https://codereview.chromium.org/954523004/diff/100001/site/dev/testing/buildbot.md File site/dev/testing/buildbot.md (right): https://codereview.chromium.org/954523004/diff/100001/site/dev/testing/buildbot.md#newcode52 site/dev/testing/buildbot.md:52: revision On 2015/02/25 18:25:23, borenet wrote: > I might ...
5 years, 10 months ago (2015-02-26 04:27:33 UTC) #6
borenet
On 2015/02/26 04:27:33, hcm wrote: > https://codereview.chromium.org/954523004/diff/100001/site/dev/testing/buildbot.md > File site/dev/testing/buildbot.md (right): > > https://codereview.chromium.org/954523004/diff/100001/site/dev/testing/buildbot.md#newcode52 > ...
5 years, 10 months ago (2015-02-26 12:14:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954523004/120001
5 years, 9 months ago (2015-03-02 19:20:01 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 19:25:29 UTC) #10
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/281bf5249c2930ff4e8a500c8c26deb8e3253b11

Powered by Google App Engine
This is Rietveld 408576698